Uploaded image for project: 'Qt for Python'
  1. Qt for Python
  2. PYSIDE-1637

shiboken6 installs unnecessary files

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reported
    • Priority: P3: Somewhat important
    • Resolution: Unresolved
    • Affects Version/s: 6.1.1
    • Fix Version/s: None
    • Component/s: Build System
    • Labels:
      None
    • Platform/s:
      All

      Description

      We noticed shiboken6 installs all kind of unrelated files in the python folder:

      • empty build dirs,
      • random files with shiboken6 is the name

      The reason is shibokenmodule/CMakeLists.txt which contains:

      install(DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/../"
       DESTINATION "${PYTHON_SITE_PACKAGES}/shiboken6/"
       FILES_MATCHING PATTERN "shiboken6.*")

      1/ From the CMake documentation:

      The DIRECTORY form installs contents of one or more directories to a given destination. The directory structure is copied verbatim to the destination.

      So, regardless of the FILES_MATCHING parameter, empty folders are created

      2/ The filter is too vague and unrelated files are installed in ${PYTHON_SITE_PACKAGES}/shiboken6/. e.g.: shiboken6.pc

        Attachments

        For Gerrit Dashboard: PYSIDE-1637
        # Subject Branch Project Status CR V

          Activity

            People

            Assignee:
            crmaurei Cristian Maureira-Fredes
            Reporter:
            cgiboudeaux Christophe Giboudeaux
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:

                Gerrit Reviews

                There is 1 open Gerrit change