Details
-
Bug
-
Resolution: Unresolved
-
P3: Somewhat important
-
None
-
6.1.1
-
None
Description
We noticed shiboken6 installs all kind of unrelated files in the python folder:
- empty build dirs,
- random files with shiboken6 is the name
The reason is shibokenmodule/CMakeLists.txt which contains:
install(DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/../" DESTINATION "${PYTHON_SITE_PACKAGES}/shiboken6/" FILES_MATCHING PATTERN "shiboken6.*")
1/ From the CMake documentation:
The DIRECTORY form installs contents of one or more directories to a given destination. The directory structure is copied verbatim to the destination.
So, regardless of the FILES_MATCHING parameter, empty folders are created
2/ The filter is too vague and unrelated files are installed in ${PYTHON_SITE_PACKAGES}/shiboken6/. e.g.: shiboken6.pc
Attachments
Gerrit Reviews
For Gerrit Dashboard: PYSIDE-1637 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
364522,1 | WIP: shiboken6: reduce files copy to install directory | dev | pyside/pyside-setup | Status: NEW | -2 | 0 |
364729,2 | shiboken: remove the temporary shiboken6 alias | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |