Details
-
Bug
-
Resolution: Done
-
P3: Somewhat important
-
None
-
6.2.9
-
None
-
All
-
3aab0899ef4f966d3a37c0e95b0e7d0f047de3e0 (pyside/pyside-setup/dev) 1e6b06cec98f4467acfa25a95fbbcf240c3ddcf6 (pyside/pyside-setup/6.2), b08cb33e0 (dev), f2ac9b0bb (6.5), abfa35aee (tqtc/lts-6.2)
Description
Calling QIcon.addPixmap(str) no longer works, producing:
TypeError: 'QIcon.addPixmap' called with wrong argument types:
QIcon.addPixmap(str)
Supported signatures:
QIcon.addPixmap(Union[QPixmap,QImage, str],
QIcon.Mode =QIcon.Mode.Normal,
QIcon.State =QIcon.State.Off)
This was caused by "pathlib: support all cases which are found in the examples"
10abd17ffb8826e4aa5861f89642c46c47b641a8 https://codereview.qt-project.org/c/pyside/pyside-setup/+/358423 which changed QPixmap(QString)
to take a path-like, breaking the implicit conversion from strings.
A workaround is to call addPixmap(QPixmap(str)).
Further classes where the constructors were modified to take a PathLike which could be relevant for implicit conversions: QDir, QFileInfo, QPixmap, QImage.
Ditto QFile, but that is not used for conversions.
Attachments
Issue Links
- relates to
-
-
- Closed
-
- resulted from
-
PYSIDE-1499 Migrate to pathlib.Path and Support __fspath__ in PySide
-
- Closed
-
| For Gerrit Dashboard: PYSIDE-1669 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 376443,6 | Inactive: Add explicit constructors for PyPathlike modifications (not really) | dev | pyside/pyside-setup | Status: NEW | 0 | 0 |
| 374258,4 | WIP: Fix QIcon.addPixmap() to accept a str argument | dev | pyside/pyside-setup | Status: ABANDONED | -2 | 0 |
| 376607,6 | Fix QIcon.addPixmap() to accept a PyPathLike argument | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 376621,5 | Add an option to disable implicit conversions | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 376786,2 | Add an option to disable implicit conversions | 6.2 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 378755,2 | Fix QIcon.addPixmap() to accept a PyPathLike argument | 6.2 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 490742,3 | shiboken6: Fix option --no-implicit-conversions | dev | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 491162,2 | shiboken6: Fix option --no-implicit-conversions | 6.5 | pyside/pyside-setup | Status: MERGED | +2 | 0 |
| 491163,3 | shiboken6: Fix option --no-implicit-conversions | tqtc/lts-6.2 | pyside/tqtc-pyside-setup | Status: MERGED | +2 | 0 |