Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-101180

As a user of QTestLib, I'm concerned about the runtime effects of the unconditional message formatting in QVERIFY2

    XMLWordPrintable

    Details

    • Type: User Story
    • Status: Open
    • Priority: P2: Important
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Testing: qtestlib
    • Labels:

      Description

      Currently, the description expressin is evaluated for each QVERIFY2(), regardless of whether it succeeds or not, even though the result is only needed when the check fails. We have thousands of test cases, and the string formatting eats a significant amount of the runtime compared to the (typically trivial) cost of the check.

      Please change QVERIFY2 to only evaluate the expressions on failure (incl. XPASS).

       

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              cnn Qt Core & Network
              Reporter:
              mmutz Marc Mutz
              PM Owner:
              Vladimir Minenko Vladimir Minenko
              RnD Owner:
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Gerrit Reviews

                  There are no open Gerrit changes