Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-101180

As a user of QTestLib, I'm concerned about the runtime effects of the unconditional message formatting in QVERIFY2

    XMLWordPrintable

Details

    • User Story
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Testing: qtestlib

    Description

      Currently, the description expressin is evaluated for each QVERIFY2(), regardless of whether it succeeds or not, even though the result is only needed when the check fails. We have thousands of test cases, and the string formatting eats a significant amount of the runtime compared to the (typically trivial) cost of the check.

      Please change QVERIFY2 to only evaluate the expressions on failure (incl. XPASS).

       

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-81473 Add QString overloads for the message/description argument of QVERIFY2 and friends

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              cnn Qt Core & Network
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes