Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-101340

Use qt_generate_deploy_qml_app_script MACOS_BUNDLE_POST_BUILD in QML examples

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 6.3.0
    • Build System: CMake
    • None
    • a6bd1dc3e (dev), 442665fd9 (6.7)

    Description

      We should use qt_generate_deploy_qml_app_script's MACOS_BUNDLE_POST_BUILD option in our QML examples to simplify their code and ensure that the examples run from inside a macOS app bundle in the build dir.
      We should include a comment above each usage of the option telling why it's needed and shouldn't be removed.

      Here are some examples that currently handle all the bundle-specific magic manually

      https://github.com/qt/qtdeclarative/blob/6e8f6f446ac8854fd23cb3cbf0fc1f3646299ca6/examples/quick/text/CMakeLists.txt#L67
      https://github.com/qt/qtdeclarative/blob/6e8f6f446ac8854fd23cb3cbf0fc1f3646299ca6/examples/quick/shared/CMakeLists.txt#L38
      https://github.com/qt/qtdeclarative/blob/6e8f6f446ac8854fd23cb3cbf0fc1f3646299ca6/examples/quick/shared/QtBundleQmlModuleForMacOS.cmake

      https://github.com/qt/qtdeclarative/blob/6e8f6f446ac8854fd23cb3cbf0fc1f3646299ca6/examples/qml/tutorials/extending-qml/chapter6-plugins/Charts/CMakeLists.txt#L19

      Proposed here
      https://git.qt.io/alcroito/qt6-cmake-api-review/-/blob/master/api_review_qt_6_3_deploy.md#L284

      Split from QTBUG-100925

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. QTBUG-96232 Figure out how to build examples as ExternalProjects in a prefix build setup so it can be used in the CI

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • In Progress

          Suggestion - Public suggestions QTBUG-90820 Build examples as external projects within the main build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • In Progress
          relates to

          Task - A task that needs to be done. QTBUG-102057 Use CMake deployment API in Qt examples once the API is out of TP

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • In Progress

          Suggestion - Public suggestions QTBUG-97741 Add App.app/Contents/PlugIns/qml as a default qml import path for macOS apps

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          resulted from

          Sub-task - The sub-task of the issue QTBUG-100925 Address review of qt_generate_deploy_qml_app_script for 6.3

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          For Gerrit Dashboard: QTBUG-101340
          # Subject Branch Project Status CR V
          551187,2 CMake: Add deployment API to our examples dev qt/qtquick3d Status: NEW +2 0
          551188,3 CMake: Add deployment API to our examples dev qt/qtdoc Status: NEW 0 0
          551412,1 WIP: CMake: Add deployment API to documentviewer dev qt/qtdoc Status: NEW -2 0
          548920,25 CMake: Add deployment API to our examples dev qt/qtdeclarative Status: MERGED +2 0
          551787,3 CMake: Add deployment API to our examples 6.7 qt/qtdeclarative Status: MERGED +2 0

          Activity

            People

              qtbuildsystem Qt Build System Team
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are 3 open Gerrit changes