Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96232

Figure out how to build examples as ExternalProjects in a prefix build setup so it can be used in the CI

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • 6.2.0 Beta3
    • Build System: CMake
    • None
    • 4e70ab5ee (dev), 432083949 (tqtc/lts-6.2), abe3e465b (tqtc/lts-6.2), 72de1af9e (tqtc/lts-6.2), 15cfb9392 (dev)

    Description

      Currently if Qt is configured as a prefix build, examples are built in-tree as part of the main Qt build, rather than as ExternalProjects.

      We should figure out how to build examples as ExternalProjects in prefix builds so that we can use that in the CI (which uses prefix builds) so that we have more robust build testing of our examples without the pollution of the main Qt build (e.g already found Qt packages).

      Some details at

      https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-047a2ba634d2540c2357d7ad913c7f752c793554

      https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-9b7be35fc48218cbc73c29d03ff99312b7532477

      From a quick 5 second brainstorming, we might not need to "make install" Qt before the example projects are configured as a big standalone project each spawning an ExternalProject, we might be able to use CMake's export(EXPORT) to create Config and Targets file referencing targets in the build tree, and set the ExternalProject CMAKE_PREFIX_PATH to the location containing those files.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. QTBUG-101340 Use qt_generate_deploy_qml_app_script MACOS_BUNDLE_POST_BUILD in QML examples

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          depends on

          Task - A task that needs to be done. QTBUG-106431 qmlimportscanner doesn't find non-installed qtdeclarative qml modules in a prefix build

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-98787 Prefix builds of qtdeclarative with examples are faced with an empty default import path when building the examples

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported

          Task - A task that needs to be done. QTBUG-102057 Use CMake deployment API in Qt examples once the API is out of TP

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94608 Nonsensical full path to examples

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-98545 Provide CMake API for deployment support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-106021 Wrong install path for shared example project

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-96358 ShaderTools package not found when building qtdeclarative examples in-tree in a prefix build (not as ExternalProjects)

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-102879 Examples not linking to Qt::Core are installed in the wrong folder

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Task - A task that needs to be done. QTBUG-102056 Remove usage of INSTALL_EXAMPLESDIR and INSTALL_EXAMPLEDIR in examples

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          resulted from

          Suggestion - Public suggestions QTBUG-90820 Build examples as external projects within the main build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • In Progress
          For Gerrit Dashboard: QTBUG-96232
          # Subject Branch Project Status CR V
          394002,16 CMake: Re-enable building external examples in prefix builds dev qt/qtbase Status: NEW -2 0
          431085,8 WIP: CMake: Test examples as external projects dev qt/qt5 Status: NEW -2 0
          492658,10 CMake: Make examples build as external projects dev qt/qtgrpc Status: NEW -1 0
          492683,4 CMake: Allow passing extra variables to external project examples dev qt/qtbase Status: NEW 0 0
          493102,3 CMake: Pass CMAKE_MODULE_PATH to external project examples dev qt/qtbase Status: NEW 0 0
          494049,2 CMake: Disable ExternalProject examples for -debug-and-release builds dev qt/qtbase Status: NEW 0 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are 6 open Gerrit changes