Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-96232

Figure out how to build examples as ExternalProjects in a prefix build setup so it can be used in the CI

    XMLWordPrintable

Details

    • Task
    • Status: In Progress
    • P3: Somewhat important
    • Resolution: Unresolved
    • 6.2.0 Beta3
    • None
    • Build System: CMake
    • None
    • 4e70ab5ee (dev), 432083949 (tqtc/lts-6.2), abe3e465b (tqtc/lts-6.2), 72de1af9e (tqtc/lts-6.2), 15cfb9392 (dev)

    Description

      Currently if Qt is configured as a prefix build, examples are built in-tree as part of the main Qt build, rather than as ExternalProjects.

      We should figure out how to build examples as ExternalProjects in prefix builds so that we can use that in the CI (which uses prefix builds) so that we have more robust build testing of our examples without the pollution of the main Qt build (e.g already found Qt packages).

      Some details at

      https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-047a2ba634d2540c2357d7ad913c7f752c793554

      https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-9b7be35fc48218cbc73c29d03ff99312b7532477

      From a quick 5 second brainstorming, we might not need to "make install" Qt before the example projects are configured as a big standalone project each spawning an ExternalProject, we might be able to use CMake's export(EXPORT) to create Config and Targets file referencing targets in the build tree, and set the ExternalProject CMAKE_PREFIX_PATH to the location containing those files.

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. QTBUG-101340 Use qt_generate_deploy_qml_app_script MACOS_BUNDLE_POST_BUILD in QML examples

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          depends on

          Task - A task that needs to be done. QTBUG-106431 qmlimportscanner doesn't find non-installed qtdeclarative qml modules in a prefix build

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-98787 Prefix builds of qtdeclarative with examples are faced with an empty default import path when building the examples

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported

          Task - A task that needs to be done. QTBUG-102057 Use CMake deployment API in Qt examples once the API is out of TP

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Reported
          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-94608 Nonsensical full path to examples

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-98545 Provide CMake API for deployment support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-106021 Wrong install path for shared example project

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-96358 ShaderTools package not found when building qtdeclarative examples in-tree in a prefix build (not as ExternalProjects)

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-102879 Examples not linking to Qt::Core are installed in the wrong folder

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed

          Task - A task that needs to be done. QTBUG-102056 Remove usage of INSTALL_EXAMPLESDIR and INSTALL_EXAMPLEDIR in examples

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          resulted from

          Suggestion - Public suggestions QTBUG-90820 Build examples as external projects within the main build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • In Progress
          For Gerrit Dashboard: QTBUG-96232
          # Subject Branch Project Status CR V
          394002,16 CMake: Re-enable building external examples in prefix builds dev qt/qtbase Status: NEW -2 0
          431085,4 WIP: CMake: Test examples as external projects dev qt/qt5 Status: NEW -2 0
          364769,12 CMake: Run export(EXPORT) for prefixed and top-level builds dev qt/qtbase Status: MERGED +2 0
          368783,7 CMake: Allow opting out of building examples as ExternalProjects dev qt/qtbase Status: MERGED +2 0
          369289,2 CMake: Allow opting out of building examples as ExternalProjects 6.2 qt/qtbase Status: MERGED +2 0
          385686,23 CMake: Build examples as ExternalProjects in prefix builds dev qt/qtbase Status: MERGED +2 0
          386411,9 CMake: Shorten ExternalProject example project paths dev qt/qtbase Status: MERGED +2 0
          386412,11 CMake: Deduce install prefix of example in qt_internal_add_example dev qt/qtbase Status: MERGED +2 0
          386689,9 CMake: Copy FindFoo.cmake scripts to build dir in prefix builds dev qt/qtbase Status: MERGED +2 0
          386873,10 CMake: Allow installing examples outside of the Qt prefix dev qt/qtbase Status: MERGED +2 0
          393360,3 CMake: Run export(EXPORT) for prefixed and top-level builds 6.3 qt/qtbase Status: MERGED +2 0
          393361,2 CMake: Run export(EXPORT) for prefixed and top-level builds 6.2 qt/qtbase Status: MERGED +2 0
          393364,4 CMake: Allow installing examples outside of the Qt prefix 6.3 qt/qtbase Status: MERGED +2 0
          393365,4 CMake: Allow installing examples outside of the Qt prefix 6.2 qt/qtbase Status: MERGED +2 0
          393366,2 CMake: Shorten ExternalProject example project paths 6.2 qt/qtbase Status: MERGED +2 0
          393367,3 CMake: Shorten ExternalProject example project paths 6.3 qt/qtbase Status: MERGED +2 0
          393390,3 CMake: Deduce install prefix of example in qt_internal_add_example 6.2 qt/qtbase Status: MERGED +2 0
          393391,3 CMake: Deduce install prefix of example in qt_internal_add_example 6.3 qt/qtbase Status: MERGED +2 0
          393392,3 CMake: Copy FindFoo.cmake scripts to build dir in prefix builds 6.3 qt/qtbase Status: MERGED +2 0
          393393,2 CMake: Copy FindFoo.cmake scripts to build dir in prefix builds 6.2 qt/qtbase Status: MERGED +2 0
          393394,3 CMake: Build examples as ExternalProjects in prefix builds 6.2 qt/qtbase Status: MERGED +2 0
          393395,3 CMake: Build examples as ExternalProjects in prefix builds 6.3 qt/qtbase Status: MERGED +2 0
          393732,2 CMake: Temporarily disable building external examples in prefix builds dev qt/qtbase Status: MERGED +2 0
          393775,7 CMake: Fix cross-building examples in prefix builds as ExternalProjects dev qt/qtbase Status: MERGED +2 0
          393776,7 CMake: Don't rely on CMAKE_FIND_ROOT_PATH_MODE_PACKAGE for examples dev qt/qtbase Status: MERGED -1 0
          393835,3 CMake: Temporarily disable building external examples in prefix builds 6.3 qt/qtbase Status: MERGED +2 0
          393836,2 CMake: Temporarily disable building external examples in prefix builds 6.2 qt/qtbase Status: MERGED +2 0
          400957,2 CMake: Fix cross-building examples in prefix builds as ExternalProjects 6.3 qt/qtbase Status: MERGED +2 0
          400958,2 CMake: Fix cross-building examples in prefix builds as ExternalProjects 6.2 qt/qtbase Status: MERGED +2 0
          400962,2 CMake: Don't rely on CMAKE_FIND_ROOT_PATH_MODE_PACKAGE for examples 6.3 qt/qtbase Status: MERGED +2 0
          400963,2 CMake: Don't rely on CMAKE_FIND_ROOT_PATH_MODE_PACKAGE for examples 6.2 qt/qtbase Status: MERGED +2 0
          401565,7 CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR dev qt/qtbase Status: MERGED +2 0
          402732,5 CMake: Allow specifying custom install dir for non-EP examples dev qt/qtbase Status: MERGED +2 0
          404238,3 CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR 6.3 qt/qtbase Status: MERGED +2 0
          404239,3 CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR 6.2 qt/qtbase Status: MERGED +2 0
          404302,3 CMake: Allow specifying custom install dir for non-EP examples 6.3 qt/qtbase Status: MERGED +2 0
          404303,3 CMake: Allow specifying custom install dir for non-EP examples 6.2 qt/qtbase Status: MERGED +2 0
          424838,3 CMake: Fix Ninja Multi-Config dependency issues for top-level targets dev qt/qtbase Status: MERGED +2 0
          424886,5 CMake: Fix examples to build as external projects when cross-compiling dev qt/qtbase Status: MERGED +2 0
          425300,2 CMake: Fix Ninja Multi-Config dependency issues for top-level targets 6.4 qt/qtbase Status: MERGED +2 0
          425301,2 CMake: Fix Ninja Multi-Config dependency issues for top-level targets 6.3 qt/qtbase Status: MERGED +2 0
          425302,2 CMake: Fix examples to build as external projects when cross-compiling 6.4 qt/qtbase Status: MERGED +2 0
          425303,2 CMake: Fix examples to build as external projects when cross-compiling 6.3 qt/qtbase Status: MERGED +2 0
          425309,2 CMake: Fix Ninja Multi-Config dependency issues for top-level targets tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          425310,2 CMake: Fix examples to build as external projects when cross-compiling tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          431445,3 CMake: Harden construction of QML import paths for qmlimportscanner dev qt/qtdeclarative Status: MERGED +2 0
          431517,3 CMake: Correctly process root paths for qmlimportscanner dev qt/qtdeclarative Status: MERGED +2 0
          431778,3 CMake: Harden construction of QML import paths for qmlimportscanner 6.4 qt/qtdeclarative Status: MERGED +2 0
          431779,2 CMake: Harden construction of QML import paths for qmlimportscanner 6.3 qt/qtdeclarative Status: MERGED +2 0
          431780,2 CMake: Harden construction of QML import paths for qmlimportscanner 6.4.0 qt/qtdeclarative Status: MERGED +2 0
          431781,3 CMake: Correctly process root paths for qmlimportscanner 6.4 qt/qtdeclarative Status: MERGED +2 0
          431782,2 CMake: Correctly process root paths for qmlimportscanner 6.4.0 qt/qtdeclarative Status: MERGED +2 0
          431783,2 CMake: Correctly process root paths for qmlimportscanner 6.3 qt/qtdeclarative Status: MERGED +2 0
          431789,4 CMake: Harden construction of QML import paths for qmlimportscanner tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: MERGED +2 0
          431790,4 CMake: Correctly process root paths for qmlimportscanner tqtc/lts-6.2 qt/tqtc-qtdeclarative Status: MERGED +2 0
          431800,7 CMake: Rework tool wrapper shell script creation dev qt/qtbase Status: MERGED +2 0
          432115,6 CMake: Add function to get tool wrapper shell script path dev qt/qtbase Status: MERGED +2 0
          432139,5 CMake: Use _qt_internal_get_tool_wrapper_script_path dev qt/qtdeclarative Status: MERGED +2 0
          432474,3 CMake: Move __qt_internal_prefix_paths_to_roots dev qt/qtbase Status: MERGED +2 0
          433046,3 CMake: Move __qt_internal_prefix_paths_to_roots 6.4 qt/qtbase Status: MERGED +2 0
          433047,4 CMake: Rework tool wrapper shell script creation 6.4 qt/qtbase Status: MERGED +2 0
          433048,4 CMake: Add function to get tool wrapper shell script path 6.4 qt/qtbase Status: MERGED +2 0
          440676,4 CMake: Use _qt_internal_get_tool_wrapper_script_path 6.4 qt/qtdeclarative Status: MERGED +2 0
          455210,2 CMake: Work around AUTOUIC Ninja Multi-Config issue with EP examples dev qt/qtbase Status: MERGED +2 0
          455211,2 CMake: Exclude designer from dependencies when building EP examples dev qt/qttools Status: MERGED +2 0
          457403,3 CMake: Move __qt_internal_prefix_paths_to_roots tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          457404,3 CMake: Rework tool wrapper shell script creation tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          457405,3 CMake: Add function to get tool wrapper shell script path tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0

          Activity

            People

              alexandru.croitor Alexandru Croitor
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are 2 open Gerrit changes