Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-102056

Remove usage of INSTALL_EXAMPLESDIR and INSTALL_EXAMPLEDIR in examples

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • 6.2.4, 6.3.0
    • Build System: CMake
    • None
    • 3b30b0fc2 (dev), d899a9abd (6.7), a6bd1dc3e (dev), 442665fd9 (6.7), f267ed7b1 (dev), cde9cfb96 (dev), 1a74168c8 (6.7), e59ac7556 (6.7)

    Description

      Once QTBUG-90820 and QTBUG-96232 are fixed (use ExternalProjects for examples in CI), and all examples are built using qt_internal_add_example() API calls,
      we should remove all usages of INSTALL_EXAMPLESDIR and INSTALL_EXAMPLEDIR in examples.

      Those were only added to ensure examples are installed under an example-relative directory, rather than $qt_prefix/bin.

      See the following comments for some historical details

      https://bugreports.qt.io/browse/QTBUG-98545?focusedCommentId=600495&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-600495

      https://bugreports.qt.io/browse/QTBUG-98545?focusedCommentId=600505&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-600505

      https://bugreports.qt.io/browse/QTBUG-98545?focusedCommentId=600939&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-600939

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. QTBUG-96232 Figure out how to build examples as ExternalProjects in a prefix build setup so it can be used in the CI

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open

          Suggestion - Public suggestions QTBUG-90820 Build examples as external projects within the main build

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-98545 Provide CMake API for deployment support

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-102057 Use CMake deployment API in Qt examples once the API is out of TP

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-136539 Add deployment to application examples

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Open
          For Gerrit Dashboard: QTBUG-102056
          # Subject Branch Project Status CR V
          548782,16 CMake: Add deployment API to our examples dev qt/qtbase Status: MERGED +2 0
          548920,25 CMake: Add deployment API to our examples dev qt/qtdeclarative Status: MERGED +2 0
          550751,2 CMake: Add deployment API to our examples 6.7 qt/qtbase Status: MERGED +2 0
          551187,4 CMake: Add deployment API to our examples dev qt/qtquick3d Status: MERGED +2 +1
          551188,5 CMake: Add deployment API to our examples dev qt/qtdoc Status: MERGED +2 +1
          551412,2 WIP: CMake: Add deployment API to documentviewer dev qt/qtdoc Status: DEFERRED -2 0
          551787,3 CMake: Add deployment API to our examples 6.7 qt/qtdeclarative Status: MERGED +2 0
          560066,3 CMake: Add deployment API to our examples 6.7 qt/qtquick3d Status: MERGED +2 0
          560914,3 CMake: Add deployment API to our examples 6.7 qt/qtdoc Status: MERGED +2 0
          576343,2 CMake: Add deployment API to our examples dev qt/qtserialport Status: DEFERRED 0 +1
          576344,2 CMake: Add deployment API to our examples dev qt/qtcoap Status: DEFERRED 0 +1
          576345,2 CMake: Add deployment API to our examples dev qt/qtnetworkauth Status: DEFERRED 0 +1
          576346,1 CMake: Add deployment API to our examples dev qt/qtactiveqt Status: DEFERRED 0 +1
          576347,1 CMake: Add deployment API to our examples dev qt/qtdltlogging Status: DEFERRED 0 +1
          576348,1 CMake: Add deployment API to our examples dev qt/qtserialbus Status: DEFERRED 0 +1
          576349,1 CMake: Add deployment API to our examples dev qt/qtmqtt Status: DEFERRED 0 +1
          576350,1 CMake: Add deployment API to our examples dev qt/qt5compat Status: DEFERRED 0 +1
          576353,1 CMake: Add deployment API to our examples dev qt/qtscxml Status: DEFERRED 0 +1
          576354,6 WIP: CMake: Add deployment API to our examples dev qt/qtopcua Status: DEFERRED -2 0
          576355,1 CMake: Add deployment API to our examples dev qt/qtsensors Status: DEFERRED 0 +1
          576356,1 CMake: Add deployment API to our examples dev qt/qtconnectivity Status: DEFERRED 0 +1
          576357,1 CMake: Add deployment API to our examples dev qt/qtwebsockets Status: DEFERRED 0 +1
          576358,2 CMake: Add deployment API to our examples dev qt/qttools Status: DEFERRED 0 +1
          576359,1 WIP: CMake: Add deployment API to our examples part two dev qt/qttools Status: DEFERRED -2 0
          576360,1 CMake: Add deployment API to our examples dev qt/qtgrpc Status: DEFERRED 0 +1
          576381,1 CMake: Add deployment API to our examples dev qt/qtwayland Status: DEFERRED 0 +1
          576383,1 CMake: Add deployment API to our examples dev qt/qtpositioning Status: DEFERRED 0 +1
          576384,1 CMake: Add deployment API to our examples dev qt/qtremoteobjects Status: DEFERRED 0 +1
          576385,1 CMake: Add deployment API to our examples dev qt/qtwebchannel Status: DEFERRED 0 +1
          576386,1 CMake: Add deployment API to our examples dev qt/qthttpserver Status: DEFERRED 0 +1
          576387,1 WIP: CMake: Add deployment API to our examples dev qt/qtdeviceutilities Status: DEFERRED -2 0
          576388,1 CMake: Add deployment API to our examples dev qt/tqtc-qtvncserver Status: DEFERRED 0 +1
          576389,2 WIP: CMake: Add deployment API to our examples dev qt/qtinterfaceframework Status: DEFERRED -2 0
          576390,2 CMake: Add deployment API to our examples dev qt/qtlocation Status: DEFERRED 0 +1
          576391,2 CMake: Add deployment API to our examples dev qt/qtmultimedia Status: DEFERRED 0 +1
          576392,2 WIP: CMake: Add deployment API to our examples dev qt/qtmultimedia Status: DEFERRED -2 0
          576393,1 CMake: Add deployment API to our examples dev qt/qtquickeffectmaker Status: DEFERRED 0 +1
          576394,1 CMake: Add deployment API to our examples dev qt/qtquick3dphysics Status: DEFERRED 0 +1
          576395,1 CMake: Add deployment API to our examples dev qt/qtgraphs Status: DEFERRED 0 +1
          576396,1 CMake: Add deployment API to our examples dev qt/qtwebengine Status: DEFERRED 0 -1
          576397,1 WIP: CMake: Add deployment API to our examples dev qt/qtapplicationmanager Status: DEFERRED -2 0
          576398,1 CMake: Add deployment API to our examples dev qt/qtwebview Status: DEFERRED 0 +1
          576399,2 CMake: Add deployment API to our examples dev qt/qt3d Status: DEFERRED 0 -1
          576400,1 CMake: Add deployment API to our examples dev qt/qtcharts Status: DEFERRED 0 +1
          576401,1 CMake: Add deployment API to our examples dev qt/qtdatavis3d Status: DEFERRED 0 -1
          576402,1 CMake: Add deployment API to our examples dev qt/qtspeech Status: DEFERRED 0 -1
          576403,1 CMake: Add deployment API to our examples dev qt/qtvirtualkeyboard Status: DEFERRED 0 +1
          576404,1 WIP: CMake: Add deployment API to our examples dev qt/tqtc-android-automotive Status: DEFERRED -2 -1
          576405,3 CMake: Add deployment API to our examples dev qt-labs/qtvehicleservices Status: DEFERRED 0 -1

          Activity

            People

              qtbuildsystem Qt Build System Team
              alexandru.croitor Alexandru Croitor
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes