Loading...

XML

Word

Printable

Type: Task
Resolution: Unresolved
Priority: P3: Somewhat important
Fix Version/s: None
Affects Version/s: 6.2.0 Beta3
Component/s: Build System: CMake
Labels:
None

Commits:
4e70ab5ee (dev), 432083949 (tqtc/lts-6.2), abe3e465b (tqtc/lts-6.2), 72de1af9e (tqtc/lts-6.2), 15cfb9392 (dev), 4a71a001a (tqtc/lts-6.5), 68b2e1db0 (dev), 43d0c5ed6 (dev), 20bd9fad1 (dev), 31c5d50e8 (dev), c668dd404 (dev), cc537d927 (dev), 40fa36db2 (dev)

Currently if Qt is configured as a prefix build, examples are built in-tree as part of the main Qt build, rather than as ExternalProjects.

We should figure out how to build examples as ExternalProjects in prefix builds so that we can use that in the CI (which uses prefix builds) so that we have more robust build testing of our examples without the pollution of the main Qt build (e.g already found Qt packages).

Some details at

https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-047a2ba634d2540c2357d7ad913c7f752c793554

https://codereview.qt-project.org/c/qt/qtbase/+/334565/16#message-9b7be35fc48218cbc73c29d03ff99312b7532477

From a quick 5 second brainstorming, we might not need to "make install" Qt before the example projects are configured as a big standalone project each spawning an ExternalProject, we might be able to use CMake's export(EXPORT) to create Config and Targets file referencing targets in the build tree, and set the ExternalProject CMAKE_PREFIX_PATH to the location containing those files.

blocks

QTBUG-101340 Use qt_generate_deploy_qml_app_script MACOS_BUNDLE_POST_BUILD in QML examples

Open

depends on

QTBUG-106431 qmlimportscanner doesn't find non-installed qtdeclarative qml modules in a prefix build

Closed

is required for

QTBUG-98787 Prefix builds of qtdeclarative with examples are faced with an empty default import path when building the examples

Reported

QTBUG-102057 Use CMake deployment API in Qt examples once the API is out of TP

Open

relates to

QTBUG-94608 Nonsensical full path to examples

Closed

QTBUG-98545 Provide CMake API for deployment support

Closed

QTBUG-106021 Wrong install path for shared example project

Reported

QTBUG-96358 ShaderTools package not found when building qtdeclarative examples in-tree in a prefix build (not as ExternalProjects)

Closed

QTBUG-102879 Examples not linking to Qt::Core are installed in the wrong folder

Closed

QTBUG-102056 Remove usage of INSTALL_EXAMPLESDIR and INSTALL_EXAMPLEDIR in examples

Reported

QTBUG-124009 Support a way to easily set import paths for QML engine & tooling

Closed

resulted from

QTBUG-90820 Build examples as external projects within the main build

Open

(6 relates to, 1 resulted from)

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-96232
#	Subject	Branch	Project	Status	CR	V
394002,28	CMake: Re-enable building external examples in prefix builds	dev	qt/qtbase	Status: NEW	-2	-1
431085,18	WIP: CMake: Test examples as external projects	dev	qt/qt5	Status: NEW	-2	0
400957,2	CMake: Fix cross-building examples in prefix builds as ExternalProjects	6.3	qt/qtbase	Status: MERGED	+2	0
400958,2	CMake: Fix cross-building examples in prefix builds as ExternalProjects	6.2	qt/qtbase	Status: MERGED	+2	0
400962,2	CMake: Don't rely on CMAKE_FIND_ROOT_PATH_MODE_PACKAGE for examples	6.3	qt/qtbase	Status: MERGED	+2	0
400963,2	CMake: Don't rely on CMAKE_FIND_ROOT_PATH_MODE_PACKAGE for examples	6.2	qt/qtbase	Status: MERGED	+2	0
401565,7	CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR	dev	qt/qtbase	Status: MERGED	+2	0
402732,5	CMake: Allow specifying custom install dir for non-EP examples	dev	qt/qtbase	Status: MERGED	+2	0
404238,3	CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR	6.3	qt/qtbase	Status: MERGED	+2	0
404239,3	CMake: Rename QT_INTERNAL_CUSTOM_INSTALL_DIR	6.2	qt/qtbase	Status: MERGED	+2	0
404302,3	CMake: Allow specifying custom install dir for non-EP examples	6.3	qt/qtbase	Status: MERGED	+2	0
404303,3	CMake: Allow specifying custom install dir for non-EP examples	6.2	qt/qtbase	Status: MERGED	+2	0
424838,3	CMake: Fix Ninja Multi-Config dependency issues for top-level targets	dev	qt/qtbase	Status: MERGED	+2	0
424886,5	CMake: Fix examples to build as external projects when cross-compiling	dev	qt/qtbase	Status: MERGED	+2	0
425300,2	CMake: Fix Ninja Multi-Config dependency issues for top-level targets	6.4	qt/qtbase	Status: MERGED	+2	0
425301,2	CMake: Fix Ninja Multi-Config dependency issues for top-level targets	6.3	qt/qtbase	Status: MERGED	+2	0
425302,2	CMake: Fix examples to build as external projects when cross-compiling	6.4	qt/qtbase	Status: MERGED	+2	0
425303,2	CMake: Fix examples to build as external projects when cross-compiling	6.3	qt/qtbase	Status: MERGED	+2	0
425309,2	CMake: Fix Ninja Multi-Config dependency issues for top-level targets	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
425310,2	CMake: Fix examples to build as external projects when cross-compiling	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
431445,3	CMake: Harden construction of QML import paths for qmlimportscanner	dev	qt/qtdeclarative	Status: MERGED	+2	0
431517,3	CMake: Correctly process root paths for qmlimportscanner	dev	qt/qtdeclarative	Status: MERGED	+2	0
431778,3	CMake: Harden construction of QML import paths for qmlimportscanner	6.4	qt/qtdeclarative	Status: MERGED	+2	0
431779,2	CMake: Harden construction of QML import paths for qmlimportscanner	6.3	qt/qtdeclarative	Status: MERGED	+2	0
431780,2	CMake: Harden construction of QML import paths for qmlimportscanner	6.4.0	qt/qtdeclarative	Status: MERGED	+2	0
431781,3	CMake: Correctly process root paths for qmlimportscanner	6.4	qt/qtdeclarative	Status: MERGED	+2	0
431782,2	CMake: Correctly process root paths for qmlimportscanner	6.4.0	qt/qtdeclarative	Status: MERGED	+2	0
431783,2	CMake: Correctly process root paths for qmlimportscanner	6.3	qt/qtdeclarative	Status: MERGED	+2	0
431789,4	CMake: Harden construction of QML import paths for qmlimportscanner	tqtc/lts-6.2	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
431790,4	CMake: Correctly process root paths for qmlimportscanner	tqtc/lts-6.2	qt/tqtc-qtdeclarative	Status: MERGED	+2	0
431800,7	CMake: Rework tool wrapper shell script creation	dev	qt/qtbase	Status: MERGED	+2	0
432115,6	CMake: Add function to get tool wrapper shell script path	dev	qt/qtbase	Status: MERGED	+2	0
432139,5	CMake: Use _qt_internal_get_tool_wrapper_script_path	dev	qt/qtdeclarative	Status: MERGED	+2	0
432474,3	CMake: Move __qt_internal_prefix_paths_to_roots	dev	qt/qtbase	Status: MERGED	+2	0
433046,3	CMake: Move __qt_internal_prefix_paths_to_roots	6.4	qt/qtbase	Status: MERGED	+2	0
433047,4	CMake: Rework tool wrapper shell script creation	6.4	qt/qtbase	Status: MERGED	+2	0
433048,4	CMake: Add function to get tool wrapper shell script path	6.4	qt/qtbase	Status: MERGED	+2	0
440676,4	CMake: Use _qt_internal_get_tool_wrapper_script_path	6.4	qt/qtdeclarative	Status: MERGED	+2	0
455210,2	CMake: Work around AUTOUIC Ninja Multi-Config issue with EP examples	dev	qt/qtbase	Status: MERGED	+2	0
455211,2	CMake: Exclude designer from dependencies when building EP examples	dev	qt/qttools	Status: MERGED	+2	0
457403,3	CMake: Move __qt_internal_prefix_paths_to_roots	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
457404,3	CMake: Rework tool wrapper shell script creation	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
457405,3	CMake: Add function to get tool wrapper shell script path	tqtc/lts-6.2	qt/tqtc-qtbase	Status: MERGED	+2	0
492658,13	CMake: Make examples build as external projects	dev	qt/qtgrpc	Status: MERGED	+2	0
492683,8	CMake: Allow passing extra variables to external project examples	dev	qt/qtbase	Status: MERGED	+2	0
493102,7	CMake: Pass CMAKE_MODULE_PATH to external project examples	dev	qt/qtbase	Status: MERGED	+2	0
493471,1	CMake: Configure examples as ExternalProjects in unique config folders	dev	qt/qtbase	Status: ABANDONED	0	0
493473,2	WIP: CMake: Only configure main config of EP examples	dev	qt/qtbase	Status: DEFERRED	-2	0
493474,3	WIP: CMake: Place syncqt directly in libexec in multi-config builds	dev	qt/qtbase	Status: DEFERRED	-2	0
493475,3	WIP: CMake: Specify explicit build command in multi config example EP	dev	qt/qtbase	Status: DEFERRED	-2	0
494049,8	CMake: Disable ExternalProject examples for -debug-and-release builds	dev	qt/qtbase	Status: MERGED	+2	0
522189,2	CMake: Work around AUTOUIC Ninja Multi-Config issue with EP examples	tqtc/lts-6.5	qt/tqtc-qtbase	Status: MERGED	+2	0
545545,4	CMake: Fix syncqt IMPORTED_LOCATION path for multi-config builds	dev	qt/qtbase	Status: MERGED	+2	0
545820,3	CMake: Adjust CMAKE_MODULE_PATH for ExternalProject examples	dev	qt/qtbase	Status: MERGED	+2	0
545849,3	CMake: Allow specifying additional glob paths for QmlPlugins.cmake	dev	qt/qtbase	Status: MERGED	+2	0
545850,3	CMake: Adjust QT_ADDITIONAL_QML_PLUGIN_GLOB_PREFIXES for EP examples	dev	qt/qtbase	Status: MERGED	+2	0
545858,16	CMake: Allow building all examples as standalone just like tests	dev	qt/qtbase	Status: MERGED	+2	0
546169,15	coin: Add instructions to build standalone examples	dev	qt/qtbase	Status: MERGED	+2	0
547206,10	coin: Build standalone examples in a separate build directory	dev	qt/qt5	Status: MERGED	+2	0
547247,16	CMake: Add option to allow skipping qml deployment when building in CI	dev	qt/qtdeclarative	Status: MERGED	+2	0
547481,6	CMake: Add option to allow skipping app deployment when building in CI	dev	qt/qtbase	Status: MERGED	+2	0
547595,5	CMake: Fix macOS deployment POST_BUILD step for debug configs	dev	qt/qtdeclarative	Status: MERGED	+2	0
547597,8	CMake: Allow configuring a minimal subset of examples to deploy	dev	qt/qtbase	Status: MERGED	+2	0
547775,3	CMake: Allow finding qmlimportscanner also in Qt build dir	dev	qt/qtdeclarative	Status: MERGED	+2	0
547776,17	CMake: Enable macOS POST_BUILD deployment for in-tree examples	dev	qt/qtdeclarative	Status: MERGED	+2	0
548407,2	CMake: Allow finding qmlimportscanner also in Qt build dir	6.7	qt/qtdeclarative	Status: MERGED	+2	0
548408,2	CMake: Fix macOS deployment POST_BUILD step for debug configs	6.7	qt/qtdeclarative	Status: MERGED	+2	0
549224,4	CMake: Fix finding standalone parts config file for yocto	dev	qt/qtbase	Status: MERGED	+2	0
549352,2	CMake: Add option to allow skipping app deployment when building in CI	6.7	qt/qtbase	Status: MERGED	+2	0
549396,4	CMake: Allow configuring a minimal subset of examples to deploy	6.7	qt/qtbase	Status: MERGED	+2	0
549502,2	CMake: Allow passing extra variables to external project examples	6.7	qt/qtbase	Status: MERGED	+2	0
549503,2	CMake: Pass CMAKE_MODULE_PATH to external project examples	6.7	qt/qtbase	Status: MERGED	+2	0
549504,2	CMake: Fix syncqt IMPORTED_LOCATION path for multi-config builds	6.7	qt/qtbase	Status: MERGED	+2	0
549505,2	CMake: Adjust CMAKE_MODULE_PATH for ExternalProject examples	6.7	qt/qtbase	Status: MERGED	+2	0
549506,2	CMake: Disable ExternalProject examples for -debug-and-release builds	6.7	qt/qtbase	Status: MERGED	+2	0
549547,2	CMake: Allow specifying additional glob paths for QmlPlugins.cmake	6.7	qt/qtbase	Status: MERGED	+2	0
549548,2	CMake: Adjust QT_ADDITIONAL_QML_PLUGIN_GLOB_PREFIXES for EP examples	6.7	qt/qtbase	Status: MERGED	+2	0
549549,2	CMake: Allow building all examples as standalone just like tests	6.7	qt/qtbase	Status: MERGED	+2	0
549550,3	coin: Add instructions to build standalone examples	6.7	qt/qtbase	Status: MERGED	+2	0
549551,2	CMake: Fix finding standalone parts config file for yocto	6.7	qt/qtbase	Status: MERGED	+2	0
551765,2	CMake: Add option to allow skipping qml deployment when building in CI	6.7	qt/qtdeclarative	Status: MERGED	+2	0
551766,2	CMake: Enable macOS POST_BUILD deployment for in-tree examples	6.7	qt/qtdeclarative	Status: MERGED	+2	0
560779,3	WIP: CMake: Allow running deployment API in top-level prefix builds	dev	qt/qtbase	Status: DEFERRED	-2	0
576606,2	CMake: Fix lookup of qml plugins for external project examples	dev	qt/qtbase	Status: MERGED	+2	0
576669,2	CMake: Fix lookup of qml plugins for external project examples	6.8	qt/qtbase	Status: MERGED	+2	0
576759,2	CMake: Fix lookup of qml plugins for external project examples	6.7	qt/qtbase	Status: MERGED	+2	0
578541,2	CMake: Don't pass __QT_DEPLOY_IMPL_DIR during macOS POST_BUILD	dev	qt/qtdeclarative	Status: MERGED	+2	0
578542,2	CMake: Unset DESTDIR when running macOS POST_BUILD deployment	dev	qt/qtdeclarative	Status: MERGED	+2	0
578543,2	coin: Unset DESTDIR after installation	dev	qt/qtbase	Status: MERGED	+2	0
578565,2	coin: Unset DESTDIR after installation	6.8	qt/qtbase	Status: MERGED	+2	0
578566,2	CMake: Don't pass __QT_DEPLOY_IMPL_DIR during macOS POST_BUILD	6.8	qt/qtdeclarative	Status: MERGED	+2	0
578567,2	CMake: Unset DESTDIR when running macOS POST_BUILD deployment	6.8	qt/qtdeclarative	Status: MERGED	+2	0
581014,4	CMake: Unset DESTDIR when installing non-standalone examples	dev	qt/qtbase	Status: MERGED	+2	+1
581679,2	CMake: Unset DESTDIR when installing non-standalone examples	6.8	qt/qtbase	Status: MERGED	+2	0
583485,3	CMake: Make grpc chat example build as external project with qemu CI	dev	qt/qtgrpc	Status: MERGED	+2	0
583981,2	CMake: Make grpc chat example build as external project with qemu CI	6.8	qt/qtgrpc	Status: MERGED	+2	0
597790,2	coin: Build MSVC as standalone examples in a separate build directory	dev	qt/qt5	Status: MERGED	+2	+1
598522,2	coin: Build MSVC as standalone examples in a separate build directory	6.8	qt/qt5	Status: MERGED	+2	0
598631,2	CMake: Fix linking of qtsvg static plugins in standalone tests build	dev	qt/qtbase	Status: MERGED	+2	0
598681,2	CMake: Fix linking of qtsvg static plugins in standalone tests build	6.8	qt/qtbase	Status: MERGED	+2	0