Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-104114

Check <=> in QCOMPARE_op

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • P2: Important
    • None
    • None
    • Testing: qtestlib
    • None
    • 8
    • Foundation Sprint 108, Foundation Sprint 109, Foundation Sprint 110

    Description

      See epic for the big picture.

      QTBUG-98873 added QCOMPARE_op for all the six traditional relational operators. It may make sense to have QCOMPARE_op(a, b) also check that (a <=> b) op 0.

      This would turn QCOMPARE_op into a static assertion for the presence of the spaceship operator and its consistency with the traditional relational operators.

      Or we create a macros specially for that (cf. QTBUG-104113), could then be private, something a bit like QCOMPARE_3WAY (QTBUG-104108), but inspecting the third argument to test also the corresponding traditional operators.

      Attachments

        Issue Links

          is required for

          Task - A task that needs to be done. QTBUG-104111 Modernize comparisons [Core: Date/Time]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-113234 Modernize comparisons [Core: QVariant]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-117660 Modernize comparisons [Core: Item Views]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Task - A task that needs to be done. QTBUG-117661 Modernize comparisons [Core: Strings]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          relates to

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-104108 As a user of QTestLib, I want to use QCOMPARE_op with C++20's spaceship operator <=>

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              tatiana.borisova Tatiana Borisova
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes