Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-111051

QTextStream shouldn't have been polymorphic

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4: Low
    • 6.6.0
    • 6.2.6, 6.4.2, 6.5.0 Beta2
    • Core: Serialization
    • None
    • All
    • 5
    • c889ffed9 (dev)
    • Foundation Sprint 75, Foundation Sprint 76

    Description

      The QTextStream class has no virtual functions others than the dtor, so it carries a vtable with no purpose other than making it less efficient than it could be and preventing adding well-defined move semantics.

      We should "deprecate" the polymorphy (adding final as an opt-in) and then make the dtor non-virtual in Qt 7.

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. QTBUG-111053 Port QtCharts examples away from inheriting QTextStream

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          For Gerrit Dashboard: QTBUG-111051
          # Subject Branch Project Status CR V
          459354,4 QTextStream: make dtor non-virtual come Qt 7 dev qt/qtbase Status: MERGED +2 0

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes