Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-112308

MPRIS name has gone back to "chromium" again

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Do
    • P2: Important
    • None
    • 6.5.0 Beta3
    • WebEngine
    • None
    • Linux/X11

    Description

      This previously came up in QTBUG-85363 and QTBUG-85475.

      Currently with a 6.5 build (7e5ee9d6aee9, from Jan, I should probably update) the MPRIS name reports as chromium again. Eg run playerctl status -l when playing a youtube video.

      There's a patch that restores it with MRPIS when run under qutebrowser. I haven't checked if pulse still shows a nice name or if that requires additional handling.

      diff --git i/chromium/components/system_media_controls/linux/system_media_controls_linux.cc w/chromium/components/system_media_controls/linux/system_media_controls_linux.cc
      index 1856668faddc..c1a0d0453dbe 100644
      --- i/chromium/components/system_media_controls/linux/system_media_controls_linux.cc
      +++ w/chromium/components/system_media_controls/linux/system_media_controls_linux.cc
      @@ -51,7 +51,7 @@ const char kMprisAPICurrentTrackPathFormatString[] =
       }  // namespace
       
       const char kMprisAPIServiceNameFormatString[] =
      -    "org.mpris.MediaPlayer2.chromium.instance%i";
      +    "org.mpris.MediaPlayer2.%s.instance%i";
       const char kMprisAPIObjectPath[] = "/org/mpris/MediaPlayer2";
       const char kMprisAPIInterfaceName[] = "org.mpris.MediaPlayer2";
       const char kMprisAPIPlayerInterfaceName[] = "org.mpris.MediaPlayer2.Player";
      @@ -61,6 +61,7 @@ SystemMediaControlsLinux::SystemMediaControlsLinux(
           const std::string& product_name)
           : product_name_(product_name),
             service_name_(base::StringPrintf(kMprisAPIServiceNameFormatString,
      +                                       product_name.c_str(),
                                              base::Process::Current().Pid())) {}
       
       SystemMediaControlsLinux::~SystemMediaControlsLinux() {
      

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qt_webengine_team Qt WebEngine Team
            toofar toofar
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes