Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-115803

Port QtWidgets away from Q_FOREACH/foreach

    XMLWordPrintable

Details

    • d03540f94 (dev), b8881ff28 (dev), 32e8b2728 (dev), b4661d511 (6.5), fecf13d65 (6.5), af34c64d7 (dev), d0a4b2913 (dev), 88464f7e9 (dev), 081670b84 (dev), ddcf71676 (dev), e0c1ae09f (dev), 4741a7cd1 (dev), d67aa6291 (dev), 067adfbb1 (6.6), aac6ba691 (6.6)

    Description

      See epic for details.

      Acceptance criteria:

      • Q_FOREACH/foreach are ported away from (see porting guide in epic before attempting anything!)
      • the #undef QT_NO_FOREACH are gone
        • files that contained them are removed from NO_PCH_SOURCES
      • the above two for both library and tests

      Attachments

        For Gerrit Dashboard: QTBUG-115803
        # Subject Branch Project Status CR V
        494761,3 GraphicsViewBenchmark: port from QList/Q_FOREACH to initializer_list/ranged-for dev qt/qtbase Status: MERGED +2 0
        494762,4 QWidget benchmark: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494763,4 QtWidgets benchmarks: port remaining users away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494765,4 tst_QMainWindow: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494766,2 tst_QMdiArea: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494767,2 tst_QComboBox: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494768,3 tst_QGroupBox: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494769,2 tst_QFileDialog/2: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494770,3 Mark QtWidgets as free of Q_FOREACH, except where it isn't dev qt/qtbase Status: MERGED +2 0
        494922,2 QTableView: add an operator<<(QDebug, SpanList) dev qt/qtbase Status: MERGED +2 0
        494923,2 QMdiArea: port Q_FOREACH to ranged-for dev qt/qtbase Status: ABANDONED -1 0
        494924,1 QtWidgets: port Q_FOREACH iterating over QMap/QHash to ranged-for dev qt/qtbase Status: ABANDONED -1 0
        494925,1 QtWidgets: port Q_FOREACH to ranged-for dev qt/qtbase Status: ABANDONED -1 0
        494929,2 tst_QGestureRecognizer: port away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        494930,2 tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations() dev qt/qtbase Status: MERGED +2 0
        494931,2 tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown() dev qt/qtbase Status: MERGED +2 0
        494932,2 tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor dev qt/qtbase Status: MERGED +2 0
        494933,2 tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor dev qt/qtbase Status: MERGED +2 0
        494934,3 tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor dev qt/qtbase Status: MERGED +2 0
        494935,1 QtWidgets tests: port remaining users away from Q_FOREACH dev qt/qtbase Status: ABANDONED +2 0
        494960,2 tst_QComboBox: port away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        494978,6 QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements dev qt/qtbase Status: MERGED +2 0
        494981,2 tst_QComboBox: port away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        494982,2 tst_QFileDialog/2: port away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        494983,2 tst_QFileDialog/2: port away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        495000,2 tst_QMdiArea: port away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        495001,2 tst_QMdiArea: port away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        495006,2 tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown() 6.5 qt/qtbase Status: MERGED +2 0
        495007,3 tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown() 6.6 qt/qtbase Status: MERGED +2 0
        495008,2 tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations() 6.5 qt/qtbase Status: MERGED +2 0
        495009,2 tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations() 6.6 qt/qtbase Status: MERGED +2 0
        495010,3 tst_QGroupBox: port away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        495011,2 tst_QGroupBox: port away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        495012,2 tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor 6.5 qt/qtbase Status: MERGED +2 0
        495013,3 tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor 6.6 qt/qtbase Status: MERGED +2 0
        495014,3 tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor 6.6 qt/qtbase Status: MERGED +2 0
        495015,2 tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor 6.5 qt/qtbase Status: MERGED +2 0
        495016,2 tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor 6.6 qt/qtbase Status: MERGED +2 0
        495017,2 tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor 6.5 qt/qtbase Status: MERGED +2 0
        495076,3 QtWidgets tests: port remaining users away from Q_FOREACH dev qt/qtbase Status: MERGED +2 0
        495549,6 QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements dev qt/qtbase Status: MERGED +2 0
        495557,4 QMdiArea: port Q_FOREACH to ranged-for, one trivial case dev qt/qtbase Status: MERGED +2 0
        495558,4 QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container dev qt/qtbase Status: MERGED +2 0
        495781,2 QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent() dev qt/qtbase Status: MERGED +2 0
        495796,3 QAbstractItemView: port Q_FOREACH to ranged-for dev qt/qtbase Status: MERGED +2 0
        495823,7 QGestureManager: port Q_FOREACH to ranged-for [1/6] dev qt/qtbase Status: MERGED +2 0
        495824,6 QGestureManager: port to ranged-for [2/6] dev qt/qtbase Status: MERGED +2 0
        495825,4 QGestureManager: port Q_FOREACH to ranged-for [3/6] dev qt/qtbase Status: MERGED +2 0
        495826,2 QPlatformTextureListWatcher: port Q_FOREACH to ranged-for dev qt/qtbase Status: MERGED +2 0
        496471,2 QtWidgets benchmarks: port remaining users away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        496472,2 QtWidgets benchmarks: port remaining users away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        496475,2 tst_QMainWindow: port away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        496476,2 tst_QMainWindow: port away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        496479,2 QtWidgets tests: port remaining users away from Q_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        496480,2 QtWidgets tests: port remaining users away from Q_FOREACH 6.5 qt/qtbase Status: MERGED +2 0
        496789,2 QMdiArea: port Q_FOREACH to ranged-for, one trivial case 6.5 qt/qtbase Status: MERGED +2 0
        496790,2 QMdiArea: port Q_FOREACH to ranged-for, one trivial case 6.6 qt/qtbase Status: MERGED +2 0
        497471,4 QGraphicsAnchorLayout: compile with QT_NO_FOREACH dev qt/qtbase Status: MERGED +2 0
        497474,4 QMenuBar: compile with QT_NO_FOREACH dev qt/qtbase Status: MERGED +2 0
        500743,2 QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements 6.5 qt/qtbase Status: MERGED +2 0
        500744,2 QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements 6.6 qt/qtbase Status: MERGED +2 0
        500745,2 QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements 6.5 qt/qtbase Status: MERGED +2 0
        500746,2 QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements 6.6 qt/qtbase Status: MERGED +2 0
        500747,2 QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container 6.6 qt/qtbase Status: MERGED +2 0
        500748,2 QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container 6.5 qt/qtbase Status: MERGED +2 0
        501080,2 QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent() 6.6 qt/qtbase Status: MERGED +2 0
        501101,2 QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent() 6.5 qt/qtbase Status: MERGED +2 0
        510256,2 QGraphicsAnchorLayout: compile with QT_NO_FOREACH 6.6 qt/qtbase Status: MERGED +2 0
        510257,1 QGraphicsAnchorLayout: compile with QT_NO_FOREACH 6.5 qt/qtbase Status: ABANDONED +2 0
        510996,3 QGestureManager: port FOREACH to ranged-for, local const QSets [4/6] dev qt/qtbase Status: MERGED +2 0
        510997,3 QGestureManager: port Q_FOREACH to ranged-for [5/6] dev qt/qtbase Status: MERGED +2 0
        511021,3 QGestureManager: port Q_FOREACH to ranged-for [6/6] dev qt/qtbase Status: MERGED +2 0
        511143,4 QWidgetRepaintManager: port Q_FOREACH to ranged-for dev qt/qtbase Status: MERGED +2 0
        511144,3 QtWidgets: finally Q_FOREACH-free dev qt/qtbase Status: MERGED +2 0

        Activity

          People

            qt.team.quick.subscriptions Qt Quick and Widgets Team
            mmutz Marc Mutz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes