Loading...

XML

Word

Printable

Details

Type: Task
Resolution: Fixed
Priority: P3: Somewhat important
Fix Version/s: None
Affects Version/s: None
Component/s: Widgets: Gesture Support, Widgets: GraphicsView, Widgets: Itemviews, Widgets: Main Window, Widgets: Widgets and Dialogs
Labels:
None

Epic Link:
Q_FOREACH
Commits:
d03540f94 (dev), b8881ff28 (dev), 32e8b2728 (dev), b4661d511 (6.5), fecf13d65 (6.5), af34c64d7 (dev), d0a4b2913 (dev), 88464f7e9 (dev), 081670b84 (dev), ddcf71676 (dev), e0c1ae09f (dev), 4741a7cd1 (dev), d67aa6291 (dev), 067adfbb1 (6.6), aac6ba691 (6.6)

Description

See epic for details.

Acceptance criteria:

Q_FOREACH/foreach are ported away from (see porting guide in epic before attempting anything!)
the #undef QT_NO_FOREACH are gone
- files that contained them are removed from NO_PCH_SOURCES
the above two for both library and tests

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Activity

People

Assignee:: Qt Quick and Widgets Team

Reporter:: Marc Mutz

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 04 Aug '23 21:27

Updated:: 02 Feb '24 19:08

Resolved:: 02 Feb '24 19:08

Gerrit Reviews

There are no open Gerrit changes

Show There are 74 closed Gerrit changes

Hide There are 74 closed Gerrit changes

GraphicsViewBenchmark: port from QList/Q_FOREACH to initializer_list/ranged-for: Gerrit Review:

QWidget benchmark: port away from Q_FOREACH: Gerrit Review:

QtWidgets benchmarks: port remaining users away from Q_FOREACH: Gerrit Review:

tst_QMainWindow: port away from Q_FOREACH: Gerrit Review:

tst_QMdiArea: port away from Q_FOREACH: Gerrit Review:

tst_QComboBox: port away from Q_FOREACH: Gerrit Review:

tst_QGroupBox: port away from Q_FOREACH: Gerrit Review:

tst_QFileDialog/2: port away from Q_FOREACH: Gerrit Review:

Mark QtWidgets as free of Q_FOREACH, except where it isn't: Gerrit Review:

QTableView: add an operator<<(QDebug, SpanList): Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for: Gerrit Review:

QtWidgets: port Q_FOREACH iterating over QMap/QHash to ranged-for: Gerrit Review:

QtWidgets: port Q_FOREACH to ranged-for: Gerrit Review:

tst_QGestureRecognizer: port away from Q_FOREACH: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations(): Gerrit Review:

tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown(): Gerrit Review:

tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor: Gerrit Review:

QtWidgets tests: port remaining users away from Q_FOREACH: Gerrit Review:

tst_QComboBox: port away from Q_FOREACH: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements: Gerrit Review:

tst_QComboBox: port away from Q_FOREACH: Gerrit Review:

tst_QFileDialog/2: port away from Q_FOREACH: Gerrit Review:

tst_QFileDialog/2: port away from Q_FOREACH: Gerrit Review:

tst_QMdiArea: port away from Q_FOREACH: Gerrit Review:

tst_QMdiArea: port away from Q_FOREACH: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown(): Gerrit Review:

tst_QWizard: port away from Q_FOREACH[2/5]: WizardPages::shown(): Gerrit Review:

tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations(): Gerrit Review:

tst_QWizard: port away from Q_FOREACH[1/5]: TestWizard::applyOperations(): Gerrit Review:

tst_QGroupBox: port away from Q_FOREACH: Gerrit Review:

tst_QGroupBox: port away from Q_FOREACH: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[5/5]: CombinationsTestData ctor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[4/5]: TestWizard dtor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor: Gerrit Review:

tst_QWizard: port away from Q_FOREACH[3/5]: OptionInfo ctor: Gerrit Review:

QtWidgets tests: port remaining users away from Q_FOREACH: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, one trivial case: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent(): Gerrit Review:

QAbstractItemView: port Q_FOREACH to ranged-for: Gerrit Review:

QGestureManager: port Q_FOREACH to ranged-for [1/6]: Gerrit Review:

QGestureManager: port to ranged-for [2/6]: Gerrit Review:

QGestureManager: port Q_FOREACH to ranged-for [3/6]: Gerrit Review:

QPlatformTextureListWatcher: port Q_FOREACH to ranged-for: Gerrit Review:

QtWidgets benchmarks: port remaining users away from Q_FOREACH: Gerrit Review:

QtWidgets benchmarks: port remaining users away from Q_FOREACH: Gerrit Review:

tst_QMainWindow: port away from Q_FOREACH: Gerrit Review:

tst_QMainWindow: port away from Q_FOREACH: Gerrit Review:

QtWidgets tests: port remaining users away from Q_FOREACH: Gerrit Review:

QtWidgets tests: port remaining users away from Q_FOREACH: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, one trivial case: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, one trivial case: Gerrit Review:

QGraphicsAnchorLayout: compile with QT_NO_FOREACH: Gerrit Review:

QMenuBar: compile with QT_NO_FOREACH: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingRearrangements: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, d->pendingPlacements: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for: loop doesn't change container: Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent(): Gerrit Review:

QMdiArea: port Q_FOREACH to ranged-for, loop could call QCA::sendEvent(): Gerrit Review:

QGraphicsAnchorLayout: compile with QT_NO_FOREACH: Gerrit Review:

QGraphicsAnchorLayout: compile with QT_NO_FOREACH: Gerrit Review:

QGestureManager: port FOREACH to ranged-for, local const QSets [4/6]: Gerrit Review:

QGestureManager: port Q_FOREACH to ranged-for [5/6]: Gerrit Review:

QGestureManager: port Q_FOREACH to ranged-for [6/6]: Gerrit Review:

QWidgetRepaintManager: port Q_FOREACH to ranged-for: Gerrit Review:

QtWidgets: finally Q_FOREACH-free: Gerrit Review: