Loading...

XML

Word

Printable

Details

Type: Task
Resolution: Unresolved
Priority: P3: Somewhat important
Fix Version/s: None
Affects Version/s: None
Component/s: Build tools: qmake, Build tools: rcc, Core: Containers and Algorithms, Core: I/O, Core: Object Model, Core: Other, Core: QtConcurrent, Core: Threads, D-Bus, Documentation, GUI: Other, GUI: Painting, GUI: Printing, GUI: Text handling, Testing: qtestlib
Labels:
None

Epic Link:
Q_FOREACH
Commits:
32cfe1812 (dev), 29f911ab9 (dev), 11c2a5b47 (dev), 3b6ae86ce (dev), a4d968adc (dev), c0738f9ff (dev), ba4b88d9d (dev), f493b72ee (dev), c9d8bcb9d (6.6), ed6914e01 (6.6), dc9e677f7 (6.6), db8a15de7 (6.6), 367cc461c (6.6), ce4f16da0 (6.5), 1f638b5ab (6.5)

Description

See epic for details.

It should be noted that, except for QtWidgets, which got its own Jira ticket (~~QTBUG-115803~~), all remaining uses are in tests/ (auto, manual, benchmarks) and util/, as well as a few platform plugins.

Acceptance criteria:

Q_FOREACH/foreach are ported away from (see porting guide in epic before attempting anything!)
the #undef QT_NO_FOREACH are gone
- files that contained them are removed from NO_PCH_SOURCES
the above two for both library and tests

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-115839
#	Subject	Branch	Project	Status	CR	V
497163,2	tst_QTextLayout: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497166,3	tst_QLockFile: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497168,2	tst_QQuaternion: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497179,2	tst_QKeyEvent: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497249,3	tst_bench_qpainter: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497250,2	tst_bench_qhash: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497251,2	tst_QArrayData: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497253,2	tst_QtBench: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: NEW	0	0
497476,2	QNX platform plugin: port Q_FOREACH to ranged-for, one trivial case	dev	qt/qtbase	Status: NEW	0	0

Activity

People

Assignee:: Qt Core & Network

Reporter:: Marc Mutz

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 07 Aug '23 14:42

Updated:: 18 Aug '23 12:15

Gerrit Reviews

There are 9 open Gerrit changes

tst_QTextLayout: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_QLockFile: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_QQuaternion: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_QKeyEvent: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_bench_qpainter: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_bench_qhash: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_QArrayData: compile with QT_NO_FOREACH

+1 Gerrit Review:
tst_QtBench: compile with QT_NO_FOREACH

+1 Gerrit Review:
QNX platform plugin: port Q_FOREACH to ranged-for, one trivial case

+1 Gerrit Review:

Show There are 73 closed Gerrit changes

Hide There are 73 closed Gerrit changes

TinyCbor: port away from Q_FOREACH: Gerrit Review:

Mark ios plugin as free of Q_FOREACH, except where it isn't: Gerrit Review:

Mark QNX plugin as free of Q_FOREACH, except where it isn't: Gerrit Review:

Mark GTK theme plugin as free of Q_FOREACH, except where it isn't: Gerrit Review:

dbus test headers: port away from Q_FOREACH: Gerrit Review:

tst_QImage: replace QList with constexpr array: Gerrit Review:

tst_QTextScriptEngine: replace QList with const array: Gerrit Review:

tst_QSctpSocket: replace QList with const array: Gerrit Review:

DynamicTreeModel test helper: port away from Q_FOREACH: Gerrit Review:

QSslSocket manual test: replace QList with const array: Gerrit Review:

tst_rcc: port away from Q_FOREACH: Gerrit Review:

QMimeDatabase benchmark: port away from Q_FOREACH: Gerrit Review:

embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH: Gerrit Review:

QStorageInfo manual test: port away from Q_FOREACH: Gerrit Review:

manual repaint test: port away from Q_FOREACH: Gerrit Review:

tst_QAccessibilityLinux: port away from Q_FOREACH: Gerrit Review:

Mark all of Qt as free of Q_FOREACH, except where it isn't: Gerrit Review:

tst_qmimedatabase: compile with QT_NO_FOREACH; port to ranged-for: Gerrit Review:

tst_QSctpSocket: replace QList with const array: Gerrit Review:

tst_QSctpSocket: replace QList with const array: Gerrit Review:

tst_QTextScriptEngine: replace QList with const array: Gerrit Review:

tst_QTextScriptEngine: replace QList with const array: Gerrit Review:

tst_QImage: replace QList with constexpr array: Gerrit Review:

tst_QImage: replace QList with constexpr array: Gerrit Review:

manual repaint test: port away from Q_FOREACH: Gerrit Review:

manual repaint test: port away from Q_FOREACH: Gerrit Review:

QSslSocket manual test: replace QList with const array: Gerrit Review:

QSslSocket manual test: replace QList with const array: Gerrit Review:

tst_QImageReader: fix a trivial Q_FOREACH and remove #undef QT_NO_FOREACH: Gerrit Review:

DynamicTreeModel test helper: port away from Q_FOREACH: Gerrit Review:

DynamicTreeModel test helper: port away from Q_FOREACH: Gerrit Review:

tst_rcc: port away from Q_FOREACH: Gerrit Review:

tst_rcc: port away from Q_FOREACH: Gerrit Review:

QStorageInfo manual test: port away from Q_FOREACH: Gerrit Review:

QStorageInfo manual test: port away from Q_FOREACH: Gerrit Review:

tst_QAccessibilityLinux: port away from Q_FOREACH: Gerrit Review:

tst_QAccessibilityLinux: port away from Q_FOREACH: Gerrit Review:

embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH: Gerrit Review:

embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH: Gerrit Review:

QtNetwork auto tests: port Q_FOREACH to ranged-for [1]: Gerrit Review:

QtNetwork auto tests: port Q_FOREACH to ranged-for [2]: Gerrit Review:

QtNetwork auto tests: port Q_FOREACH to ranged-for [3]: Gerrit Review:

QtNetwork auto tests: port Q_FOREACH to ranged-for [4]: Gerrit Review:

tst_QSslCertificate: port Q_FOREACH to ranged-for [5]: Gerrit Review:

tst_QNetworkReply: port Q_FOREACH to ranged-for: Gerrit Review:

QtNetwork auto tests: compile with QT_NO_FOREACH: Gerrit Review:

tst_QtConcurrentMedian: compile with QT_NO_FOREACH: Gerrit Review:

tst_QAbstractFileEngine: compile with QT_NO_FOREACH: Gerrit Review:

tst_QDir: port Q_FOREACH with QList::removeIf: Gerrit Review:

tst_QDir: compile with QT_NO_FOREACH: Gerrit Review:

tst_QDirIterator: build with QT_NO_FOREACH: Gerrit Review:

tests/auto/*: port Q_FOREACH to ranged-for: Gerrit Review:

tests/auto/: port Q_FOREACH to ranged-for, local const containers: Gerrit Review:

tests/auto/*: port Q_FOREACH to ranged-for, make container const: Gerrit Review:

tst_QStorageInfo: compile with QT_NO_FOREACH: Gerrit Review:

tst_QTemporaryDir/File: compile with QT_NO_FOREACH: Gerrit Review:

tst_QFreeList: build with QT_NO_FOREACH: Gerrit Review:

selftests/badxml/tst_badxml: compile with QT_NO_FOREACH: Gerrit Review:

tst_selftests: compile with QT_NO_FOREACH: Gerrit Review:

tst_moc: compile with QT_NO_FOREACH: Gerrit Review:

tst_qmake: compile with QT_NO_FOREACH: Gerrit Review:

QMimeDatabase benchmark: port away from Q_FOREACH: Gerrit Review:

QMimeDatabase benchmark: port away from Q_FOREACH: Gerrit Review:

tst_qmakelib: compile with QT_NO_FOREACH: Gerrit Review:

tst_QPrinter: compile with QT_NO_FOREACH: Gerrit Review:

tst_QPrintDevice: compile with QT_NO_FOREACH: Gerrit Review:

tst_QAccessibility: compile with QT_NO_FOREACH: Gerrit Review:

tst_Gestures: port Q_FOREACH to ranged-for: Gerrit Review:

tst_Gestures: compile with QT_NO_FOREACH [1/2]: Gerrit Review:

tst_QFont: compile with QT_NO_FOREACH: Gerrit Review:

Benchmarks: port Q_FOREACH to ranged-for: Gerrit Review:

tst_Gestures: compile with QT_NO_FOREACH [2/2]: Gerrit Review:

tests/manual/dialogs/utils.cpp: port away from Q_FOREACH: Gerrit Review: