Loading...

XML

Word

Printable

Details

Type: Task
Resolution: Unresolved
Priority: P3: Somewhat important
Fix Version/s: None
Affects Version/s: None
Component/s: Build tools: qmake, Build tools: rcc, Core: Containers and Algorithms, Core: I/O, Core: Object Model, Core: Other, Core: QtConcurrent, Core: Threads, D-Bus, Documentation, GUI: Other, GUI: Painting, GUI: Printing, GUI: Text handling, Testing: qtestlib
Labels:
None

Epic Link:
Q_FOREACH
Commits:
32cfe1812 (dev), 29f911ab9 (dev), 11c2a5b47 (dev), 3b6ae86ce (dev), a4d968adc (dev), c0738f9ff (dev), ba4b88d9d (dev), f493b72ee (dev), c9d8bcb9d (6.6), ed6914e01 (6.6), dc9e677f7 (6.6), db8a15de7 (6.6), 367cc461c (6.6), ce4f16da0 (6.5), 1f638b5ab (6.5)

Description

See epic for details.

It should be noted that, except for QtWidgets, which got its own Jira ticket (~~QTBUG-115803~~), all remaining uses are in tests/ (auto, manual, benchmarks) and util/, as well as a few platform plugins.

Acceptance criteria:

Q_FOREACH/foreach are ported away from (see porting guide in epic before attempting anything!)
the #undef QT_NO_FOREACH are gone
- files that contained them are removed from NO_PCH_SOURCES
the above two for both library and tests

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-115839
#	Subject	Branch	Project	Status	CR	V
494961,3	TinyCbor: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495077,2	Mark ios plugin as free of Q_FOREACH, except where it isn't	dev	qt/qtbase	Status: MERGED	+2	0
495078,2	Mark QNX plugin as free of Q_FOREACH, except where it isn't	dev	qt/qtbase	Status: MERGED	+2	0
495079,2	Mark GTK theme plugin as free of Q_FOREACH, except where it isn't	dev	qt/qtbase	Status: MERGED	+2	0
495080,7	dbus test headers: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495102,2	tst_QImage: replace QList with constexpr array	dev	qt/qtbase	Status: MERGED	+2	0
495103,2	tst_QTextScriptEngine: replace QList with const array	dev	qt/qtbase	Status: MERGED	+2	0
495104,2	tst_QSctpSocket: replace QList with const array	dev	qt/qtbase	Status: MERGED	+2	0
495105,3	DynamicTreeModel test helper: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495106,2	QSslSocket manual test: replace QList with const array	dev	qt/qtbase	Status: MERGED	+2	0
495107,2	tst_rcc: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495109,4	QMimeDatabase benchmark: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495110,2	embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495111,3	QStorageInfo manual test: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495112,2	manual repaint test: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495113,2	tst_QAccessibilityLinux: port away from Q_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495115,9	Mark all of Qt as free of Q_FOREACH, except where it isn't	dev	qt/qtbase	Status: MERGED	+2	0
495175,5	tst_qmimedatabase: compile with QT_NO_FOREACH; port to ranged-for	dev	qt/qtbase	Status: MERGED	+2	0
495194,2	tst_QSctpSocket: replace QList with const array	6.5	qt/qtbase	Status: MERGED	+2	0
495195,2	tst_QSctpSocket: replace QList with const array	6.6	qt/qtbase	Status: MERGED	+2	0
495196,2	tst_QTextScriptEngine: replace QList with const array	6.6	qt/qtbase	Status: MERGED	+2	0
495197,2	tst_QTextScriptEngine: replace QList with const array	6.5	qt/qtbase	Status: MERGED	+2	0
495198,2	tst_QImage: replace QList with constexpr array	6.6	qt/qtbase	Status: MERGED	+2	0
495199,2	tst_QImage: replace QList with constexpr array	6.5	qt/qtbase	Status: MERGED	+2	0
495200,2	manual repaint test: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495241,2	manual repaint test: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
495264,2	QSslSocket manual test: replace QList with const array	6.6	qt/qtbase	Status: MERGED	+2	0
495265,2	QSslSocket manual test: replace QList with const array	6.5	qt/qtbase	Status: MERGED	+2	0
495294,4	tst_QImageReader: fix a trivial Q_FOREACH and remove #undef QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
495324,2	DynamicTreeModel test helper: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495325,2	DynamicTreeModel test helper: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
495395,2	tst_rcc: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
495396,2	tst_rcc: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495397,2	QStorageInfo manual test: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495398,2	QStorageInfo manual test: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
495574,2	tst_QAccessibilityLinux: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
495575,2	tst_QAccessibilityLinux: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495578,2	embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
495579,2	embeddedintoforeignindow test: port itemwindow.h away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
496106,4	QtNetwork auto tests: port Q_FOREACH to ranged-for [1]	dev	qt/qtbase	Status: MERGED	+2	0
496107,5	QtNetwork auto tests: port Q_FOREACH to ranged-for [2]	dev	qt/qtbase	Status: MERGED	+2	0
496112,4	QtNetwork auto tests: port Q_FOREACH to ranged-for [3]	dev	qt/qtbase	Status: MERGED	+2	0
496114,6	QtNetwork auto tests: port Q_FOREACH to ranged-for [4]	dev	qt/qtbase	Status: MERGED	+2	0
496115,7	tst_QSslCertificate: port Q_FOREACH to ranged-for [5]	dev	qt/qtbase	Status: MERGED	+2	0
496116,6	tst_QNetworkReply: port Q_FOREACH to ranged-for	dev	qt/qtbase	Status: MERGED	+2	0
496120,4	QtNetwork auto tests: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496161,4	tst_QtConcurrentMedian: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496162,3	tst_QAbstractFileEngine: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496163,3	tst_QDir: port Q_FOREACH with QList::removeIf	dev	qt/qtbase	Status: MERGED	+2	0
496164,3	tst_QDir: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496165,3	tst_QDirIterator: build with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496166,4	tests/auto/*: port Q_FOREACH to ranged-for	dev	qt/qtbase	Status: MERGED	+2	0
496168,4	tests/auto/: port Q_FOREACH to ranged-for, local const containers	dev	qt/qtbase	Status: MERGED	+2	0
496170,4	tests/auto/*: port Q_FOREACH to ranged-for, make container const	dev	qt/qtbase	Status: MERGED	+2	0
496171,3	tst_QStorageInfo: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496172,4	tst_QTemporaryDir/File: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496173,3	tst_QFreeList: build with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496176,5	selftests/badxml/tst_badxml: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496177,3	tst_selftests: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496178,4	tst_moc: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496184,3	tst_qmake: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
496477,3	QMimeDatabase benchmark: port away from Q_FOREACH	6.6	qt/qtbase	Status: MERGED	+2	0
496478,3	QMimeDatabase benchmark: port away from Q_FOREACH	6.5	qt/qtbase	Status: MERGED	+2	0
496755,3	tst_qmakelib: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
497062,3	tst_QPrinter: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
497064,3	tst_QPrintDevice: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
497112,3	tst_QAccessibility: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: MERGED	+2	0
497114,2	tst_Gestures: port Q_FOREACH to ranged-for	dev	qt/qtbase	Status: ABANDONED	0	0
497161,6	tst_Gestures: compile with QT_NO_FOREACH [1/2]	dev	qt/qtbase	Status: MERGED	+2	0
497163,2	tst_QTextLayout: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497164,2	tst_QFont: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497166,3	tst_QLockFile: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497168,2	tst_QQuaternion: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497179,2	tst_QKeyEvent: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497247,4	Benchmarks: port Q_FOREACH to ranged-for	dev	qt/qtbase	Status: ABANDONED	0	0
497249,3	tst_bench_qpainter: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497250,2	tst_bench_qhash: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497251,2	tst_QArrayData: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497253,2	tst_QtBench: compile with QT_NO_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0
497476,2	QNX platform plugin: port Q_FOREACH to ranged-for, one trivial case	dev	qt/qtbase	Status: ABANDONED	0	0
510209,3	tst_Gestures: compile with QT_NO_FOREACH [2/2]	dev	qt/qtbase	Status: MERGED	+2	0
528659,2	tests/manual/dialogs/utils.cpp: port away from Q_FOREACH	dev	qt/qtbase	Status: ABANDONED	0	0