Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-119030

xcb plugin mixes up touch events for multiple windows

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P1: Critical
    • None
    • 6.0, 6.6.0
    • QPA: X11/XCB
    • None

    Description

      Found while testing QTBUG-118909:

      void QXcbConnection::xi2ProcessTouch(void *xiDevEvent, QXcbWindow *platformWindow)
{
    auto *xiDeviceEvent = reinterpret_cast<xcb_input_touch_begin_event_t *>(xiDevEvent);
    TouchDeviceData *dev = touchDeviceForId(xiDeviceEvent->sourceid);
    Q_ASSERT(dev);
    const bool firstTouch = dev->touchPoints.isEmpty();
    if (xiDeviceEvent->event_type == XCB_INPUT_TOUCH_BEGIN) {
        QWindowSystemInterface::TouchPoint tp;
        tp.id = xiDeviceEvent->detail % INT_MAX; // <-- only one touchpoint in this XI2 event
        tp.state = QEventPoint::State::Pressed;
        tp.pressure = -1.0;
        dev->touchPoints[tp.id] = tp;
    }
...
    QWindowSystemInterface::handleTouchEvent(platformWindow->window(), xiDeviceEvent->time, dev->qtTouchDevice, dev->touchPoints.values(), modifiers);

      dev->touchPoints.values() is all active touchpoints in all windows. QGuiApplicationPrivate::processTouchEvent() takes the window from the event, not the touchpoint. (QWindowSystemInterface::TouchPoint does not include the window, so we do not have the ability to send one event with touches in multiple windows via QWindowSystemInterface::handleTouchEvent(): it needs to be a separate event for each window. This could change if we start using QEventPoint there instead.) Depending on the QHash order, it might first find the pre-existing touchpoint and assign it a new window.

      Maybe this is a good reason to take care of QTBUG-119029 and start trying to send QEventPoints directly from the plugin to another overload of QWindowSystemInterface::handleTouchEvent(). It will avoid some conversion overhead; QEventPointPrivate has a QWindow*, so an event with touches in multiple windows might be ok; and, QGuiApplicationPrivate::processTouchEvent() already has code to split up the events by window.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-92054 Crash on simulated touch input via uinput at xi2ProcessTouch

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-73708 Input events stop getting handled when being touched/pressed from multiple devices

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-104771 xcb: Synthesized mouse from touch gets stuck

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Closed
          resulted from

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-118909 Touches cancelled when interacting with multiple windows

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Task - A task that needs to be done. QTBUG-119029 Get rid of QXcbConnection::TouchDeviceData; pre-construct QEventPoints in xcb plugin

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              axelspoerl Axel Spoerl
              srutledg Shawn Rutledge
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes