Details
-
Task
-
Resolution: Fixed
-
P2: Important
-
None
-
None
-
8
-
2a847dd93 (dev), fa0d77e29 (dev), 30bf16335 (dev), 473d06970 (dev), 8a54d25a4 (dev), 9d4e1b9f8 (dev), d999e6469 (dev), 9bedf8a53 (dev), eb178d3e5 (dev), a4341827a (dev), c2826805d (dev), 3ca9877f8 (dev)
-
Foundation Sprint 103, Foundation Sprint 104, Foundation Sprint 105, Foundation Sprint 106, Foundation Sprint 107
Description
See epic for the big picture and (the latest version of) QTBUG-104113 for a detailed description of the necessary changes.
This is basically QSize, QMargins, QRect, QPoint, QLine and their F variants.
The dilemma here is that op== for the F variants is broken: it uses qFuzzyCompare instead of overloading qFuzzyCompare for a proper user opt-in. So we probably need to get that API bug out of the way before we can use use the new framework on the F types.
Acceptance criteria:
- Implemented using the new framework for non-F- and mixed-type comparsions
- Implemented qFuzzy* overloads for the F types
- Deprecated op== for F versions
- Created follow-up task for Qt 7 to re-implement the F-type op=='s as exact
Attachments
Issue Links
- depends on
-
-
- Closed
-
-
QTBUG-104110
Support easy, yet precise, documenting of relational operators
-
- Closed
-
- is required for
-
-
- Closed
-
| For Gerrit Dashboard: QTBUG-120308 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 550539,10 | QPoint(F): use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 550540,10 | Add qFuzzyCompare() and qFuzzyIsNull() overloads for QPointF | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 550698,1 | WIP: Deprecate (in)equality operators for QPointF | dev | qt/qtbase | Status: ABANDONED | -2 | 0 |
| 553314,10 | QLine(F): use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 553371,8 | QLineF: add qFuzzyCompare and qFuzzyIsNull overloads | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 553401,8 | QRect(F): use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 553402,8 | QRectF: add qFuzzyCompare and qFuzzyIsNull overloads | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 555382,11 | QSize(F): use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 555679,7 | QSizeF: add qFuzzyCompare and qFuzzyIsNull overloads | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 556345,6 | Fix QMarginsF::operator==() for zero margins | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 556347,6 | QMargins(F): use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 556348,6 | QMarginsF: add qFuzzyCompare and qFuzzyIsNull overloads | dev | qt/qtbase | Status: MERGED | +2 | +1 |
| 557771,5 | QEasingCurve: use comparison helper macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |