Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-120308

Modernize comparisons [Core: Geometric Classes]

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Core: Other
    • None
    • 8
    • Foundation Sprint 103, Foundation Sprint 104, Foundation Sprint 105, Foundation Sprint 106, Foundation Sprint 107

    Description

      See epic for the big picture and (the latest version of) QTBUG-104113 for a detailed description of the necessary changes.

      This is basically QSize, QMargins, QRect, QPoint, QLine and their F variants.

      The dilemma here is that op== for the F variants is broken: it uses qFuzzyCompare instead of overloading qFuzzyCompare for a proper user opt-in. So we probably need to get that API bug out of the way before we can use use the new framework on the F types.

      Acceptance criteria:

      • Implemented using the new framework for non-F- and mixed-type comparsions
      • Implemented qFuzzy* overloads for the F types
      • Deprecated op== for F versions
      • Created follow-up task for Qt 7 to re-implement the F-type op=='s as exact

      Attachments

        Issue Links

          depends on

          Task - A task that needs to be done. QTBUG-104113 Modernize comparisons: can we provide macros?

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-104110 Support easy, yet precise, documenting of relational operators

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          is required for

          Task - A task that needs to be done. QTBUG-120304 Modernize comparisons [Core: <rest>]

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • In Progress
          For Gerrit Dashboard: QTBUG-120308
          # Subject Branch Project Status CR V
          550539,7 QPoint(F): use comparison helper macros dev qt/qtbase Status: NEW -1 0
          550540,7 Add qFuzzyCompare() and qFuzzyIsNull() overloads for QPointF dev qt/qtbase Status: NEW +2 0
          550698,1 WIP: Deprecate (in)equality operators for QPointF dev qt/qtbase Status: NEW -2 0
          553314,8 QLine(F): use comparison helper macros dev qt/qtbase Status: NEW 0 0
          553371,6 QLineF: add qFuzzyCompare and qFuzzyIsNull overloads dev qt/qtbase Status: NEW +2 0
          553401,6 QRect(F): use comparison helper macros dev qt/qtbase Status: NEW +1 0
          553402,6 QRectF: add qFuzzyCompare and qFuzzyIsNull overloads dev qt/qtbase Status: NEW +2 0
          555382,9 QSize(F): use comparison helper macros dev qt/qtbase Status: NEW +1 0
          555679,5 QSizeF: add qFuzzyCompare and qFuzzyIsNull overloads dev qt/qtbase Status: NEW +2 0
          556345,4 Fix QMarginsF::operator==() for zero margins dev qt/qtbase Status: NEW 0 0
          556347,4 QMargins(F): use comparison helper macros dev qt/qtbase Status: NEW +1 0
          556348,4 QMarginsF: add qFuzzyCompare and qFuzzyIsNull overloads dev qt/qtbase Status: NEW 0 0
          557771,2 QEasingCurve: use comparison helper macros dev qt/qtbase Status: NEW 0 0

          Activity

            People

              ivan.solovev Ivan Solovev
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: