Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-120942 GRPC API Review
  3. QTBUG-123625

Address the Grpc module API review comments

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Done
    • P2: Important
    • None
    • None
    • None
    • Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115
    • c232253fb (dev), a456f4513 (dev), 8be92d0ab (6.7), 043b046d5 (6.7), 120eea95b (dev), 0010b90f8 (dev), 2b2417922 (dev), eec7104cd (dev), 27ab146bc (dev), a61838fcf (dev), a69a58321 (dev), f7e510ad5 (dev), 6efb3db12 (dev), c8ca806f4 (dev), 17a813421 (dev)

    Attachments

      For Gerrit Dashboard: QTBUG-123625
      # Subject Branch Project Status CR V
      559662,1 QGrpcClientBase: pass shared_ptr by copy for attachChannel(~) 6.7 qt/qtgrpc Status: ABANDONED 0 0
      570593,5 QGrpcOperation: regroup includes à la TTLOFIR dev qt/qtgrpc Status: ABANDONED +2 0
      570845,3 QGrpcClientBase: regroup includes à la TTLOFIR dev qt/qtgrpc Status: ABANDONED +2 0
      574159,7 QAbstractGrpcChannel: move fwd declaration of Private to just before the public's dev qt/qtgrpc Status: MERGED +2 0
      575724,19 QGrpcSerializationFormat: drag 'Format' enum into the qtgrpc namespace dev qt/qtgrpc Status: MERGED +2 0
      575726,21 QGrpcStatus: drag 'StatusCode' enum into the qtgrpc namespace dev qt/qtgrpc Status: MERGED +2 0
      575730,25 QGrpcStatus: split message() into appropriate l&rvalue overloads dev qt/qtgrpc Status: MERGED +2 0
      575731,26 Add override(s) of 'QObject::event()' to QObject subclasses dev qt/qtgrpc Status: MERGED +2 0
      576934,20 QGrpcCallOptions: transform into implicitly shared value class dev qt/qtgrpc Status: MERGED +2 0
      576993,19 QGrpcChannelOptions: transform into implicitly shared value class dev qt/qtgrpc Status: MERGED +2 0
      576994,20 QGrpcSerializationFormat: transform into implicitly shared value class dev qt/qtgrpc Status: MERGED +2 0
      577065,18 Revert QGrpcDuration and use std::chrono::milliseconds directly again dev qt/qtgrpc Status: MERGED +2 0
      577885,2 QGrpcCallReply: remove 2 arg cb subscribe() and provide constraints 6.8 qt/qtgrpc Status: MERGED +2 0
      577886,2 QGrpcClientBase: constrain startStream() with the canonical form 6.8 qt/qtgrpc Status: MERGED +2 0
      577887,2 QGrpcOperation: constrain read() with base_of QProtobufMessage 6.8 qt/qtgrpc Status: MERGED +2 0
      577888,2 qgrpcstream: remove writeMessage(const QPM*) 6.8 qt/qtgrpc Status: MERGED +2 0
      577889,2 QGrpcHttp2ChannelPrivate: connect Http2Handler::writeMessage directly 6.8 qt/qtgrpc Status: MERGED +2 0
      577890,2 qgrpcstream: connect 'messageReceived' directly 6.8 qt/qtgrpc Status: MERGED +2 0
      578387,13 QGrpcMetadata: use QHash instead of std::unordered_multimap <QBA, QBA> dev qt/qtgrpc Status: MERGED +2 0
      579301,4 QGrpcSerializationFormat: drag 'Format' enum into the qtgrpc namespace 6.8 qt/qtgrpc Status: MERGED +2 0
      579302,3 QGrpcStatus: drag 'StatusCode' enum into the qtgrpc namespace 6.8 qt/qtgrpc Status: MERGED +2 0
      579304,3 QGrpcStatus: split message() into appropriate l&rvalue overloads 6.8 qt/qtgrpc Status: MERGED +2 0
      579305,3 Add override(s) of 'QObject::event()' to QObject subclasses 6.8 qt/qtgrpc Status: MERGED +2 0
      579308,3 QGrpcCallOptions: transform into implicitly shared value class 6.8 qt/qtgrpc Status: MERGED +2 0
      579309,3 QGrpcChannelOptions: transform into implicitly shared value class 6.8 qt/qtgrpc Status: MERGED +2 0
      579310,3 QGrpcSerializationFormat: transform into implicitly shared value class 6.8 qt/qtgrpc Status: MERGED +2 0
      579311,3 Revert QGrpcDuration and use std::chrono::milliseconds directly again 6.8 qt/qtgrpc Status: MERGED +2 0
      579312,3 QGrpcMetadata: use QHash instead of std::unordered_multimap <QBA, QBA> 6.8 qt/qtgrpc Status: MERGED +2 0
      579338,2 QGrpcSerializationFormat: transform default ctor to be Q_IMPLICIT 6.8 qt/qtgrpc Status: MERGED +2 0
      579703,2 QAbstractGrppcChannel: update IWYU and favor fwd declarations dev qt/qtgrpc Status: MERGED +2 0
      579704,2 QGrpcClientBase: update IWYU and favor fwd declarations dev qt/qtgrpc Status: MERGED +2 -1
      579706,5 QGrpcHttp2Channel: update IWYU and favor fwd declarations dev qt/qtgrpc Status: MERGED +2 +1
      579815,3 QGrpcCallReply: simplify the signature for subscribe() dev qt/qtgrpc Status: ABANDONED -1 0
      579816,7 QGrpcOperation: provide operation context as (const) ref dev qt/qtgrpc Status: MERGED +2 0
      579817,7 QGrpcSerializationFormat: make the custom ctor explicit dev qt/qtgrpc Status: MERGED +2 0
      581242,3 QAbstractGrppcChannel: update IWYU and favor fwd declarations 6.8 qt/qtgrpc Status: MERGED +2 0
      581243,3 QGrpcClientBase: update IWYU and favor fwd declarations 6.8 qt/qtgrpc Status: MERGED +2 0
      581245,4 QGrpcHttp2Channel: update IWYU and favor fwd declarations 6.8 qt/qtgrpc Status: MERGED +2 0
      581375,3 QGrpcOperation: provide operation context as (const) ref 6.8 qt/qtgrpc Status: MERGED +2 0
      581376,3 QGrpcSerializationFormat: make the custom ctor explicit 6.8 qt/qtgrpc Status: MERGED +2 0
      581951,19 QAbstractGrpcChannel: Remove the start prefix for stream methods dev qt/qtgrpc Status: MERGED +2 0
      581988,12 Rename 'bidir' -> 'bidi' to stay in line with upstream definitions dev qt/qtgrpc Status: MERGED +2 0
      582145,6 Remove the defaulted options from the generated gRPC methods dev qt/qtgrpc Status: MERGED +2 0
      582146,6 Add the nodiscard attributes to the generated gRPC methods dev qt/qtgrpc Status: MERGED +2 0
      582147,7 Add the missing dtor to the generated gRPC client classes dev qt/qtgrpc Status: MERGED +2 0
      582148,7 Adjust the header guards in the generated code dev qt/qtgrpc Status: MERGED +2 0
      582172,9 Re-arrange and cleanup includes in the generated code dev qt/qtgrpc Status: MERGED +2 0
      583868,2 Remove the defaulted options from the generated gRPC methods 6.8 qt/qtgrpc Status: MERGED +2 0
      583869,2 Add the nodiscard attributes to the generated gRPC methods 6.8 qt/qtgrpc Status: MERGED +2 0
      583870,2 Add the missing dtor to the generated gRPC client classes 6.8 qt/qtgrpc Status: MERGED +2 0
      583871,2 Adjust the header guards in the generated code 6.8 qt/qtgrpc Status: MERGED +2 0
      583872,2 Re-arrange and cleanup includes in the generated code 6.8 qt/qtgrpc Status: MERGED +2 0
      585349,4 Rename 'bidir' -> 'bidi' to stay in line with upstream definitions 6.8 qt/qtgrpc Status: MERGED +2 0
      585481,12 Remove QtGrpcQuickFunctional::handleDeserializationError from public API dev qt/qtgrpc Status: MERGED +2 0
      585582,12 Remove QGrpcOperation::deserializationError(String) methods dev qt/qtgrpc Status: MERGED +2 0
      585597,11 Allow reusing d_ptr of QAbstractGrpcChannel dev qt/qtgrpc Status: MERGED +2 0
      585598,11 Remove QGrpcClientBase::startStream method dev qt/qtgrpc Status: MERGED +2 0
      585599,12 Allow setting the channel options after the channel creation dev qt/qtgrpc Status: MERGED +2 0
      585600,15 Make the QQmlGrpcHttp2Channel options property non-required dev qt/qtgrpc Status: MERGED +2 0
      585662,6 Make the QQmlGrpcHttp2Channel hostUri property CONSTANT dev qt/qtgrpc Status: ABANDONED 0 0
      586703,2 Remove QtGrpcQuickFunctional::handleDeserializationError from public API 6.8 qt/qtgrpc Status: MERGED +2 0
      586704,2 Remove QGrpcOperation::deserializationError(String) methods 6.8 qt/qtgrpc Status: MERGED +2 0
      586710,3 Allow reusing d_ptr of QAbstractGrpcChannel 6.8 qt/qtgrpc Status: MERGED +2 0
      586711,3 QAbstractGrpcChannel: Remove the start prefix for stream methods 6.8 qt/qtgrpc Status: MERGED +2 0
      586712,3 Remove QGrpcClientBase::startStream method 6.8 qt/qtgrpc Status: MERGED +2 0
      586713,3 Allow setting the channel options after the channel creation 6.8 qt/qtgrpc Status: MERGED +2 0
      586715,3 Make the QQmlGrpcHttp2Channel options property non-required 6.8 qt/qtgrpc Status: MERGED +2 0
      588488,5 De-inline QQmlAbstractGrpcChannel dtor dev qt/qtgrpc Status: MERGED +2 0
      588489,5 Make QQmlAbstractGrpcChannel::channel const dev qt/qtgrpc Status: MERGED +2 0
      588490,6 Avoid instantiating std::make_optional() dev qt/qtgrpc Status: MERGED +2 0
      588538,4 Grpc: remove controversial noexept dev qt/qtgrpc Status: MERGED +2 0
      588539,3 QGrpcOperation: read() through optional::operator* dev qt/qtgrpc Status: MERGED +2 0
      588540,4 QGrpcSerializationFormat: move comparesEqual() out of line dev qt/qtgrpc Status: MERGED +2 0
      588541,4 QGrpcSerializationFormat: move qHash() out of line dev qt/qtgrpc Status: MERGED +2 0
      588542,3 QAbstractGrpcChannel: make non-interactive pure virtuals private dev qt/qtgrpc Status: MERGED +2 0
      588543,1 Apply consistent scope usage of common macros dev qt/qtgrpc Status: ABANDONED 0 -1
      588544,3 Apply consistent scope usage of common macros dev qt/qtgrpc Status: MERGED +2 0
      588545,3 QAbstractGrpcChannel: remove unneeded Q_DECLARE_METATYPE, shared_ptr dev qt/qtgrpc Status: MERGED +2 0
      588566,2 De-inline QQmlAbstractGrpcChannel dtor 6.8 qt/qtgrpc Status: MERGED +2 0
      588568,2 Make QQmlAbstractGrpcChannel::channel const 6.8 qt/qtgrpc Status: MERGED +2 0
      588569,2 Avoid instantiating std::make_optional() 6.8 qt/qtgrpc Status: MERGED +2 0
      588570,2 QAbstractGrpcChannel: remove unneeded Q_DECLARE_METATYPE, shared_ptr 6.8 qt/qtgrpc Status: MERGED +2 0
      588680,2 QGrpcOperationContext: use QT_DEFINE_STRUCT dev qt/qtgrpc Status: MERGED +2 0
      588719,2 Use non _EXPORT version of QESDP specialization dev qt/qtgrpc Status: MERGED +2 0
      588723,3 Grpc: remove controversial noexept 6.8 qt/qtgrpc Status: MERGED +2 0
      588724,3 QGrpcOperation: read() through optional::operator* 6.8 qt/qtgrpc Status: MERGED +2 0
      588725,3 QAbstractGrpcChannel: make non-interactive pure virtuals private 6.8 qt/qtgrpc Status: MERGED +2 0
      588726,3 Apply consistent scope usage of common macros 6.8 qt/qtgrpc Status: MERGED +2 0
      588766,3 QGrpcSerializationFormat: move comparesEqual() out of line 6.8 qt/qtgrpc Status: MERGED +2 0
      588768,3 QGrpcSerializationFormat: move qHash() out of line 6.8 qt/qtgrpc Status: MERGED +2 0
      588770,3 QGrpcOperationContext: use QT_DEFINE_STRUCT 6.8 qt/qtgrpc Status: MERGED +2 0
      588805,3 Use non _EXPORT version of QESDP specialization 6.8 qt/qtgrpc Status: MERGED +2 0
      591246,2 Grpc: remove controversial noexept 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591247,2 QGrpcOperation: read() through optional::operator* 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591248,2 QAbstractGrpcChannel: make non-interactive pure virtuals private 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591249,2 Apply consistent scope usage of common macros 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591250,2 QGrpcSerializationFormat: move comparesEqual() out of line 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591251,2 QGrpcSerializationFormat: move qHash() out of line 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591252,2 QGrpcOperationContext: use QT_DEFINE_STRUCT 6.8.0 qt/qtgrpc Status: MERGED +2 0
      591253,2 Use non _EXPORT version of QESDP specialization 6.8.0 qt/qtgrpc Status: MERGED +2 0

      Activity

        People

          dennisoberst Dennis Oberst
          semlanik Alexey Edelev
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There are no open Gerrit changes