Loading...

XML

Word

Printable

Type: Technical task
Resolution: Done
Priority: P2: Important
Fix Version/s: None
Component/s: None
Labels:
None

Sprint:
Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115
Commits:
c232253fb (dev), a456f4513 (dev), 8be92d0ab (6.7), 043b046d5 (6.7), 120eea95b (dev), 0010b90f8 (dev), 2b2417922 (dev), eec7104cd (dev), 27ab146bc (dev), a61838fcf (dev), a69a58321 (dev), f7e510ad5 (dev), 6efb3db12 (dev), c8ca806f4 (dev), 17a813421 (dev)

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

No reviews matched the request. Check your Options in the drop-down menu of this sections header.

Assignee:: Dennis Oberst

Reporter:: Alexey Edelev

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Created:: 22 Mar '24 15:39

Updated:: 16 Sep '24 18:08

Resolved:: 11 Sep '24 10:05

There are no open Gerrit changes

Show There are 100 closed Gerrit changes

Hide There are 100 closed Gerrit changes

QGrpcClientBase: pass shared_ptr by copy for attachChannel(~): Gerrit Review:

QGrpcOperation: regroup includes à la TTLOFIR: Gerrit Review:

QGrpcClientBase: regroup includes à la TTLOFIR: Gerrit Review:

QAbstractGrpcChannel: move fwd declaration of Private to just before the public's: Gerrit Review:

QGrpcSerializationFormat: drag 'Format' enum into the qtgrpc namespace: Gerrit Review:

QGrpcStatus: drag 'StatusCode' enum into the qtgrpc namespace: Gerrit Review:

QGrpcStatus: split message() into appropriate l&rvalue overloads: Gerrit Review:

Add override(s) of 'QObject::event()' to QObject subclasses: Gerrit Review:

QGrpcCallOptions: transform into implicitly shared value class: Gerrit Review:

QGrpcChannelOptions: transform into implicitly shared value class: Gerrit Review:

QGrpcSerializationFormat: transform into implicitly shared value class: Gerrit Review:

Revert QGrpcDuration and use std::chrono::milliseconds directly again: Gerrit Review:

QGrpcCallReply: remove 2 arg cb subscribe() and provide constraints: Gerrit Review:

QGrpcClientBase: constrain startStream() with the canonical form: Gerrit Review:

QGrpcOperation: constrain read() with base_of QProtobufMessage: Gerrit Review:

qgrpcstream: remove writeMessage(const QPM*): Gerrit Review:

QGrpcHttp2ChannelPrivate: connect Http2Handler::writeMessage directly: Gerrit Review:

qgrpcstream: connect 'messageReceived' directly: Gerrit Review:

QGrpcMetadata: use QHash instead of std::unordered_multimap <QBA, QBA>: Gerrit Review:

QGrpcSerializationFormat: drag 'Format' enum into the qtgrpc namespace: Gerrit Review:

QGrpcStatus: drag 'StatusCode' enum into the qtgrpc namespace: Gerrit Review:

QGrpcStatus: split message() into appropriate l&rvalue overloads: Gerrit Review:

Add override(s) of 'QObject::event()' to QObject subclasses: Gerrit Review:

QGrpcCallOptions: transform into implicitly shared value class: Gerrit Review:

QGrpcChannelOptions: transform into implicitly shared value class: Gerrit Review:

QGrpcSerializationFormat: transform into implicitly shared value class: Gerrit Review:

Revert QGrpcDuration and use std::chrono::milliseconds directly again: Gerrit Review:

QGrpcMetadata: use QHash instead of std::unordered_multimap <QBA, QBA>: Gerrit Review:

QGrpcSerializationFormat: transform default ctor to be Q_IMPLICIT: Gerrit Review:

QAbstractGrppcChannel: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcClientBase: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcHttp2Channel: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcCallReply: simplify the signature for subscribe(): Gerrit Review:

QGrpcOperation: provide operation context as (const) ref: Gerrit Review:

QGrpcSerializationFormat: make the custom ctor explicit: Gerrit Review:

QAbstractGrppcChannel: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcClientBase: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcHttp2Channel: update IWYU and favor fwd declarations: Gerrit Review:

QGrpcOperation: provide operation context as (const) ref: Gerrit Review:

QGrpcSerializationFormat: make the custom ctor explicit: Gerrit Review:

QAbstractGrpcChannel: Remove the start prefix for stream methods: Gerrit Review:

Rename 'bidir' -> 'bidi' to stay in line with upstream definitions: Gerrit Review:

Remove the defaulted options from the generated gRPC methods: Gerrit Review:

Add the nodiscard attributes to the generated gRPC methods: Gerrit Review:

Add the missing dtor to the generated gRPC client classes: Gerrit Review:

Adjust the header guards in the generated code: Gerrit Review:

Re-arrange and cleanup includes in the generated code: Gerrit Review:

Remove the defaulted options from the generated gRPC methods: Gerrit Review:

Add the nodiscard attributes to the generated gRPC methods: Gerrit Review:

Add the missing dtor to the generated gRPC client classes: Gerrit Review:

Adjust the header guards in the generated code: Gerrit Review:

Re-arrange and cleanup includes in the generated code: Gerrit Review:

Rename 'bidir' -> 'bidi' to stay in line with upstream definitions: Gerrit Review:

Remove QtGrpcQuickFunctional::handleDeserializationError from public API: Gerrit Review:

Remove QGrpcOperation::deserializationError(String) methods: Gerrit Review:

Allow reusing d_ptr of QAbstractGrpcChannel: Gerrit Review:

Remove QGrpcClientBase::startStream method: Gerrit Review:

Allow setting the channel options after the channel creation: Gerrit Review:

Make the QQmlGrpcHttp2Channel options property non-required: Gerrit Review:

Make the QQmlGrpcHttp2Channel hostUri property CONSTANT: Gerrit Review:

Remove QtGrpcQuickFunctional::handleDeserializationError from public API: Gerrit Review:

Remove QGrpcOperation::deserializationError(String) methods: Gerrit Review:

Allow reusing d_ptr of QAbstractGrpcChannel: Gerrit Review:

QAbstractGrpcChannel: Remove the start prefix for stream methods: Gerrit Review:

Remove QGrpcClientBase::startStream method: Gerrit Review:

Allow setting the channel options after the channel creation: Gerrit Review:

Make the QQmlGrpcHttp2Channel options property non-required: Gerrit Review:

De-inline QQmlAbstractGrpcChannel dtor: Gerrit Review:

Make QQmlAbstractGrpcChannel::channel const: Gerrit Review:

Avoid instantiating std::make_optional(): Gerrit Review:

Grpc: remove controversial noexept: Gerrit Review:

QGrpcOperation: read() through optional::operator*: Gerrit Review:

QGrpcSerializationFormat: move comparesEqual() out of line: Gerrit Review:

QGrpcSerializationFormat: move qHash() out of line: Gerrit Review:

QAbstractGrpcChannel: make non-interactive pure virtuals private: Gerrit Review:

Apply consistent scope usage of common macros: Gerrit Review:

Apply consistent scope usage of common macros: Gerrit Review:

QAbstractGrpcChannel: remove unneeded Q_DECLARE_METATYPE, shared_ptr: Gerrit Review:

De-inline QQmlAbstractGrpcChannel dtor: Gerrit Review:

Make QQmlAbstractGrpcChannel::channel const: Gerrit Review:

Avoid instantiating std::make_optional(): Gerrit Review:

QAbstractGrpcChannel: remove unneeded Q_DECLARE_METATYPE, shared_ptr: Gerrit Review:

QGrpcOperationContext: use QT_DEFINE_STRUCT: Gerrit Review:

Use non _EXPORT version of QESDP specialization: Gerrit Review:

Grpc: remove controversial noexept: Gerrit Review:

QGrpcOperation: read() through optional::operator*: Gerrit Review:

QAbstractGrpcChannel: make non-interactive pure virtuals private: Gerrit Review:

Apply consistent scope usage of common macros: Gerrit Review:

QGrpcSerializationFormat: move comparesEqual() out of line: Gerrit Review:

QGrpcSerializationFormat: move qHash() out of line: Gerrit Review:

QGrpcOperationContext: use QT_DEFINE_STRUCT: Gerrit Review:

Use non _EXPORT version of QESDP specialization: Gerrit Review:

Grpc: remove controversial noexept: Gerrit Review:

QGrpcOperation: read() through optional::operator*: Gerrit Review:

QAbstractGrpcChannel: make non-interactive pure virtuals private: Gerrit Review:

Apply consistent scope usage of common macros: Gerrit Review:

QGrpcSerializationFormat: move comparesEqual() out of line: Gerrit Review:

QGrpcSerializationFormat: move qHash() out of line: Gerrit Review:

QGrpcOperationContext: use QT_DEFINE_STRUCT: Gerrit Review:

Use non _EXPORT version of QESDP specialization: Gerrit Review: