Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-120942 GRPC API Review
  3. QTBUG-123626

Address the Protobuf module API review comments

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Done
    • Not Evaluated
    • None
    • None
    • None
    • Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115
    • c77999a1f (dev), 267922b40 (6.7), a624621ad (dev), 814fb1a91 (dev), 829664402 (dev), 44a6a65b3 (dev), e9f0c7411 (6.7), 8eb50d512 (dev), bcecfbef9 (dev), 93d818a52 (dev), 41efeaca3 (dev), f6de52bfa (dev), 3e9049712 (dev), f84bd17c9 (dev), 751f36b76 (dev)

    Attachments

      For Gerrit Dashboard: QTBUG-123626
      # Subject Branch Project Status CR V
      588500,1 WIP: Avoid dangerous reinterpret_cast conversion dev qt/qtgrpc Status: NEW -2 0
      564464,8 Replace (de)serializeObject interface with (de)serializeProperty dev qt/qtgrpc Status: ABANDONED 0 0
      574677,2 Change the QProtobufMessage::constructByName signature dev qt/qtgrpc Status: ABANDONED 0 0
      574763,28 Remove the QtProtobufMessage::detachPrivate() interface dev qt/qtgrpc Status: MERGED +2 0
      574770,25 Prefer using std::conjunction_v in IsProtobufMessageType constraint dev qt/qtgrpc Status: MERGED +2 0
      574897,20 Change the HasProtobufPropertyOrdering meta function dev qt/qtgrpc Status: MERGED +2 0
      574899,27 Remove the QtProtobuf::repeatedValueCompare function dev qt/qtgrpc Status: MERGED +2 0
      574922,35 Use QT_DEFINE_TAG_STRUCT for NonConstTag dev qt/qtgrpc Status: MERGED +2 0
      574924,35 Rename QProtobufMessagePrivate::getPropertyIndex dev qt/qtgrpc Status: MERGED +2 0
      574925,34 Unwrap QtProtobufPrivate::registerHandler handler argument dev qt/qtgrpc Status: MERGED +2 0
      575111,26 Rename IsProtobufMessageType and IsNonMessageProtobufType constaints dev qt/qtgrpc Status: MERGED +2 0
      575263,27 Change the (de)serialize handler interface dev qt/qtgrpc Status: MERGED +2 0
      575266,24 Avoid pointer-based overload of QProtobufOneof::value dev qt/qtgrpc Status: MERGED +2 0
      575267,26 Cache the message pointer in QProtobufOneof::isEqual method dev qt/qtgrpc Status: MERGED +2 0
      575269,20 Scope the QtProtobufPrivate::FieldFlag enum dev qt/qtgrpc Status: MERGED +2 0
      575270,24 Move the QVariant initialization to QProtobufOneof::ensureRawValue dev qt/qtgrpc Status: MERGED +2 0
      577643,17 Remove the explicit scope of the deserializationError return type dev qt/qtgrpc Status: MERGED +2 0
      577646,28 Add qHash implementation for the QtProtobuf::TransparentWrapper dev qt/qtgrpc Status: MERGED +2 0
      577772,28 Allow re-using the QProtobufMessage d_ptr in derived classes dev qt/qtgrpc Status: MERGED +2 0
      577776,28 Use copy-and-swap and move-assignment swap in generated code dev qt/qtgrpc Status: MERGED +2 0
      577801,29 Remove the mutable getters for repeated and map types dev qt/qtgrpc Status: MERGED +2 0
      578516,8 Remove the noexcept modifier from QProtobufMessageDeleter::operator() dev qt/qtgrpc Status: ABANDONED -2 0
      580820,2 Move the serializer check assert to a separate function 6.8 qt/qtgrpc Status: MERGED +2 0
      580841,2 Rename the TransparentWrapper::_t member to t 6.8 qt/qtgrpc Status: MERGED +2 0
      580842,2 Move Q_ASSERT from QProtobufOneof methods to a separate one 6.8 qt/qtgrpc Status: MERGED +2 0
      580843,2 Scope the QtProtobufPrivate::FieldFlag enum 6.8 qt/qtgrpc Status: MERGED +2 0
      580844,2 Use QT_DEFINE_TAG_STRUCT for NonConstTag 6.8 qt/qtgrpc Status: MERGED +2 0
      580860,2 Remove the explicit scope of the deserializationError return type 6.8 qt/qtgrpc Status: MERGED +2 0
      580873,2 Move the QVariant initialization to QProtobufOneof::ensureRawValue 6.8 qt/qtgrpc Status: MERGED +2 0
      581921,2 Prefer using std::conjunction_v in IsProtobufMessageType constraint 6.8 qt/qtgrpc Status: MERGED +2 0
      581922,2 Unwrap QtProtobufPrivate::registerHandler handler argument 6.8 qt/qtgrpc Status: MERGED +2 0
      582172,9 Re-arrange and cleanup includes in the generated code dev qt/qtgrpc Status: MERGED +2 0
      583828,2 Remove the QtProtobufMessage::detachPrivate() interface 6.8 qt/qtgrpc Status: MERGED +2 0
      583829,2 Rename QProtobufMessagePrivate::getPropertyIndex 6.8 qt/qtgrpc Status: MERGED +2 0
      583830,2 Rename IsProtobufMessageType and IsNonMessageProtobufType constaints 6.8 qt/qtgrpc Status: MERGED +2 0
      583831,2 Change the (de)serialize handler interface 6.8 qt/qtgrpc Status: MERGED +2 0
      583833,2 Avoid pointer-based overload of QProtobufOneof::value 6.8 qt/qtgrpc Status: MERGED +2 0
      583834,2 Cache the message pointer in QProtobufOneof::isEqual method 6.8 qt/qtgrpc Status: MERGED +2 0
      583838,2 Allow re-using the QProtobufMessage d_ptr in derived classes 6.8 qt/qtgrpc Status: MERGED +2 0
      583840,2 Use copy-and-swap and move-assignment swap in generated code 6.8 qt/qtgrpc Status: MERGED +2 0
      583861,2 Remove the mutable getters for repeated and map types 6.8 qt/qtgrpc Status: MERGED +2 0
      583872,2 Re-arrange and cleanup includes in the generated code 6.8 qt/qtgrpc Status: MERGED +2 0
      584657,3 Make QtProtobufPrivate::findHandler private API dev qt/qtgrpc Status: MERGED +2 0
      584658,10 Move all semi-public API from QProtobufMessage dev qt/qtgrpc Status: MERGED +2 0
      584659,14 Remove QAbstractProtobufSerializer::(de)serializeObject interface dev qt/qtgrpc Status: MERGED +2 0
      584939,6 Remove the Q_QDOC special declaration of qRegisterProtobufEnumType() dev qt/qtgrpc Status: MERGED +2 0
      585399,2 Add qHash implementation for the QtProtobuf::TransparentWrapper 6.8 qt/qtgrpc Status: MERGED +2 0
      585401,2 Make QtProtobufPrivate::findHandler private API 6.8 qt/qtgrpc Status: MERGED +2 0
      585448,19 Make the protobuf serializer registry private dev qt/qtgrpc Status: MERGED +2 0
      585469,16 Adjust protobuf constrains across repo code dev qt/qtgrpc Status: MERGED +2 0
      585470,2 Fix header guards in qprotobufmessage.h and qprotobufmessage_p.h dev qt/qtgrpc Status: MERGED +2 0
      585476,13 Cleanup includes in the QtProtobuf module dev qt/qtgrpc Status: MERGED +2 0
      585479,11 Add the rvalue overload for QProtobufOneof::setValue dev qt/qtgrpc Status: MERGED +2 0
      585498,2 Remove the Q_QDOC special declaration of qRegisterProtobufEnumType() 6.8 qt/qtgrpc Status: MERGED +2 0
      585500,2 Fix header guards in qprotobufmessage.h and qprotobufmessage_p.h 6.8 qt/qtgrpc Status: MERGED +2 0
      585575,2 Move all semi-public API from QProtobufMessage 6.8 qt/qtgrpc Status: MERGED +2 0
      585576,2 Remove QAbstractProtobufSerializer::(de)serializeObject interface 6.8 qt/qtgrpc Status: MERGED +2 0
      585585,12 Make error handling in QAbstractProtobufSerializer generic dev qt/qtgrpc Status: MERGED +2 0
      585991,4 Fix the leak in QProtobufMapEntry dev qt/qtgrpc Status: MERGED +2 0
      585993,13 Add rvalue setter to the generated messages dev qt/qtgrpc Status: MERGED +2 0
      585995,11 Add ref-qualifiers for the non-trivially copyable type getters dev qt/qtgrpc Status: MERGED +2 0
      585996,11 Generate the lvalue cref getters for the non-trivially copyable types dev qt/qtgrpc Status: MERGED +2 +1
      586277,2 Fix the leak in QProtobufMapEntry 6.8 qt/qtgrpc Status: MERGED +2 0
      586676,2 Make the protobuf serializer registry private 6.8 qt/qtgrpc Status: MERGED +2 0
      586677,2 Adjust protobuf constrains across repo code 6.8 qt/qtgrpc Status: MERGED +2 0
      586678,2 Cleanup includes in the QtProtobuf module 6.8 qt/qtgrpc Status: MERGED +2 0
      586681,2 Add the rvalue overload for QProtobufOneof::setValue 6.8 qt/qtgrpc Status: MERGED +2 0
      586705,3 Make error handling in QAbstractProtobufSerializer generic 6.8 qt/qtgrpc Status: MERGED +2 0
      586720,3 Add rvalue setter to the generated messages 6.8 qt/qtgrpc Status: MERGED +2 0
      586721,3 Add ref-qualifiers for the non-trivially copyable type getters 6.8 qt/qtgrpc Status: MERGED +2 0
      586722,3 Generate the lvalue cref getters for the non-trivially copyable types 6.8 qt/qtgrpc Status: MERGED +2 0
      588484,5 Make QAbstractProtobufSerializer:(de)serializeMessage private dev qt/qtgrpc Status: MERGED +2 0
      588485,5 Scope QAbstractProtobufSerializer::Error enum dev qt/qtgrpc Status: MERGED +2 +1
      588486,3 Remove todo from QProtobufLazyMessagePointerBase dev qt/qtgrpc Status: MERGED +2 0
      588487,4 Remove faulty noexept promises dev qt/qtgrpc Status: MERGED +2 0
      588492,5 QProtobufOneof: Inline non-const rawValue dev qt/qtgrpc Status: MERGED +2 0
      588493,2 QProtobufRepeatedIterator: Use qt_ptr_swap instead of std::swap dev qt/qtgrpc Status: MERGED +2 0
      588494,3 QProtobufOneof: Replace reinterpret_cast with static_cast dev qt/qtgrpc Status: MERGED +2 0
      588495,2 QProtobufOneof: Implement move-assignment using QT_MOVE_..._PURE_SWAP dev qt/qtgrpc Status: MERGED +2 0
      588496,3 QProtobufMapEntry: Adjust the key() and value() methods return value dev qt/qtgrpc Status: MERGED +2 0
      588497,3 Use the scope for QProtobufMapEntry::metaCall dev qt/qtgrpc Status: MERGED +2 0
      588498,2 QProtobufLazyMessagePointerBase: Implement move-assignment using QT_MOVE_..._PURE_SWAP dev qt/qtgrpc Status: MERGED +2 0
      588499,4 Rid of the QT_DECL_METATYPE_EXTERN_TAGGED for TransparentWrapper types dev qt/qtgrpc Status: MERGED +2 0
      588501,2 Fix the detach in the string-enum list converters dev qt/qtgrpc Status: MERGED +2 0
      588517,2 QProtobufOneof: Inline non-const rawValue 6.8 qt/qtgrpc Status: MERGED +2 0
      588519,2 QProtobufRepeatedIterator: Use qt_ptr_swap instead of std::swap 6.8 qt/qtgrpc Status: MERGED +2 0
      588520,2 Make QAbstractProtobufSerializer:(de)serializeMessage private 6.8 qt/qtgrpc Status: MERGED +2 0
      588521,2 QProtobufOneof: Replace reinterpret_cast with static_cast 6.8 qt/qtgrpc Status: MERGED +2 0
      588531,12 Rid of the QtProtobufPrivate::AbstractRepeatedIterator dev qt/qtgrpc Status: MERGED +2 0
      588562,2 Remove todo from QProtobufLazyMessagePointerBase 6.8 qt/qtgrpc Status: MERGED +2 0
      588563,2 QProtobufOneof: Implement move-assignment using QT_MOVE_..._PURE_SWAP 6.8 qt/qtgrpc Status: MERGED +2 0
      588564,2 Remove faulty noexept promises 6.8 qt/qtgrpc Status: MERGED +2 0
      588565,2 Use the scope for QProtobufMapEntry::metaCall 6.8 qt/qtgrpc Status: MERGED +2 0
      588567,2 QProtobufLazyMessagePointerBase: Implement move-assignment using QT_MOVE_..._PURE_SWAP 6.8 qt/qtgrpc Status: MERGED +2 0
      588764,2 Scope QAbstractProtobufSerializer::Error enum 6.8 qt/qtgrpc Status: MERGED +2 0
      588765,2 QProtobufMapEntry: Adjust the key() and value() methods return value 6.8 qt/qtgrpc Status: MERGED +2 0
      588767,2 Rid of the QT_DECL_METATYPE_EXTERN_TAGGED for TransparentWrapper types 6.8 qt/qtgrpc Status: MERGED +2 0
      588769,2 Fix the detach in the string-enum list converters 6.8 qt/qtgrpc Status: MERGED +2 0
      588888,1 Avoid indeterminate initialization of protobuf messages dev qt/qtgrpc Status: ABANDONED +2 0
      589138,2 Rid of the QtProtobufPrivate::AbstractRepeatedIterator 6.8 qt/qtgrpc Status: MERGED +2 0

      Activity

        People

          Unassigned Unassigned
          semlanik Alexey Edelev
          Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

            Created:
            Updated:
            Resolved:

            Gerrit Reviews

              There is 1 open Gerrit change