Loading...

XML

Word

Printable

Details

Type: Technical task
Resolution: Done
Priority: Not Evaluated
Fix Version/s: None
Component/s: None
Labels:
None

Sprint:
Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115
Commits:
c77999a1f (dev), 267922b40 (6.7), a624621ad (dev), 814fb1a91 (dev), 829664402 (dev), 44a6a65b3 (dev), e9f0c7411 (6.7), 8eb50d512 (dev), bcecfbef9 (dev), 93d818a52 (dev), 41efeaca3 (dev), f6de52bfa (dev), 3e9049712 (dev), f84bd17c9 (dev), 751f36b76 (dev)

Attachments

Gerrit Reviews

- Issue Only
- Show All Reviews
- Show Open Reviews
- Show All Issues
- Show Open Issues

For Gerrit Dashboard: QTBUG-123626
#	Subject	Branch	Project	Status	CR	V
588500,1	WIP: Avoid dangerous reinterpret_cast conversion	dev	qt/qtgrpc	Status: NEW	-2	0

Activity

People

Assignee:: Unassigned

Reporter:: Alexey Edelev

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 22 Mar '24 15:40

Updated:: 11 Sep '24 10:05

Resolved:: 11 Sep '24 10:05

Gerrit Reviews

There is 1 open Gerrit change

WIP: Avoid dangerous reinterpret_cast conversion

-2 Gerrit Review:

Show There are 99 closed Gerrit changes

Hide There are 99 closed Gerrit changes

Replace (de)serializeObject interface with (de)serializeProperty: Gerrit Review:

Change the QProtobufMessage::constructByName signature: Gerrit Review:

Remove the QtProtobufMessage::detachPrivate() interface: Gerrit Review:

Prefer using std::conjunction_v in IsProtobufMessageType constraint: Gerrit Review:

Change the HasProtobufPropertyOrdering meta function: Gerrit Review:

Remove the QtProtobuf::repeatedValueCompare function: Gerrit Review:

Use QT_DEFINE_TAG_STRUCT for NonConstTag: Gerrit Review:

Rename QProtobufMessagePrivate::getPropertyIndex: Gerrit Review:

Unwrap QtProtobufPrivate::registerHandler handler argument: Gerrit Review:

Rename IsProtobufMessageType and IsNonMessageProtobufType constaints: Gerrit Review:

Change the (de)serialize handler interface: Gerrit Review:

Avoid pointer-based overload of QProtobufOneof::value: Gerrit Review:

Cache the message pointer in QProtobufOneof::isEqual method: Gerrit Review:

Scope the QtProtobufPrivate::FieldFlag enum: Gerrit Review:

Move the QVariant initialization to QProtobufOneof::ensureRawValue: Gerrit Review:

Remove the explicit scope of the deserializationError return type: Gerrit Review:

Add qHash implementation for the QtProtobuf::TransparentWrapper: Gerrit Review:

Allow re-using the QProtobufMessage d_ptr in derived classes: Gerrit Review:

Use copy-and-swap and move-assignment swap in generated code: Gerrit Review:

Remove the mutable getters for repeated and map types: Gerrit Review:

Remove the noexcept modifier from QProtobufMessageDeleter::operator(): Gerrit Review:

Move the serializer check assert to a separate function: Gerrit Review:

Rename the TransparentWrapper::_t member to t: Gerrit Review:

Move Q_ASSERT from QProtobufOneof methods to a separate one: Gerrit Review:

Scope the QtProtobufPrivate::FieldFlag enum: Gerrit Review:

Use QT_DEFINE_TAG_STRUCT for NonConstTag: Gerrit Review:

Remove the explicit scope of the deserializationError return type: Gerrit Review:

Move the QVariant initialization to QProtobufOneof::ensureRawValue: Gerrit Review:

Prefer using std::conjunction_v in IsProtobufMessageType constraint: Gerrit Review:

Unwrap QtProtobufPrivate::registerHandler handler argument: Gerrit Review:

Re-arrange and cleanup includes in the generated code: Gerrit Review:

Remove the QtProtobufMessage::detachPrivate() interface: Gerrit Review:

Rename QProtobufMessagePrivate::getPropertyIndex: Gerrit Review:

Rename IsProtobufMessageType and IsNonMessageProtobufType constaints: Gerrit Review:

Change the (de)serialize handler interface: Gerrit Review:

Avoid pointer-based overload of QProtobufOneof::value: Gerrit Review:

Cache the message pointer in QProtobufOneof::isEqual method: Gerrit Review:

Allow re-using the QProtobufMessage d_ptr in derived classes: Gerrit Review:

Use copy-and-swap and move-assignment swap in generated code: Gerrit Review:

Remove the mutable getters for repeated and map types: Gerrit Review:

Re-arrange and cleanup includes in the generated code: Gerrit Review:

Make QtProtobufPrivate::findHandler private API: Gerrit Review:

Move all semi-public API from QProtobufMessage: Gerrit Review:

Remove QAbstractProtobufSerializer::(de)serializeObject interface: Gerrit Review:

Remove the Q_QDOC special declaration of qRegisterProtobufEnumType(): Gerrit Review:

Add qHash implementation for the QtProtobuf::TransparentWrapper: Gerrit Review:

Make QtProtobufPrivate::findHandler private API: Gerrit Review:

Make the protobuf serializer registry private: Gerrit Review:

Adjust protobuf constrains across repo code: Gerrit Review:

Fix header guards in qprotobufmessage.h and qprotobufmessage_p.h: Gerrit Review:

Cleanup includes in the QtProtobuf module: Gerrit Review:

Add the rvalue overload for QProtobufOneof::setValue: Gerrit Review:

Remove the Q_QDOC special declaration of qRegisterProtobufEnumType(): Gerrit Review:

Fix header guards in qprotobufmessage.h and qprotobufmessage_p.h: Gerrit Review:

Move all semi-public API from QProtobufMessage: Gerrit Review:

Remove QAbstractProtobufSerializer::(de)serializeObject interface: Gerrit Review:

Make error handling in QAbstractProtobufSerializer generic: Gerrit Review:

Fix the leak in QProtobufMapEntry: Gerrit Review:

Add rvalue setter to the generated messages: Gerrit Review:

Add ref-qualifiers for the non-trivially copyable type getters: Gerrit Review:

Generate the lvalue cref getters for the non-trivially copyable types: Gerrit Review:

Fix the leak in QProtobufMapEntry: Gerrit Review:

Make the protobuf serializer registry private: Gerrit Review:

Adjust protobuf constrains across repo code: Gerrit Review:

Cleanup includes in the QtProtobuf module: Gerrit Review:

Add the rvalue overload for QProtobufOneof::setValue: Gerrit Review:

Make error handling in QAbstractProtobufSerializer generic: Gerrit Review:

Add rvalue setter to the generated messages: Gerrit Review:

Add ref-qualifiers for the non-trivially copyable type getters: Gerrit Review:

Generate the lvalue cref getters for the non-trivially copyable types: Gerrit Review:

Make QAbstractProtobufSerializer:(de)serializeMessage private: Gerrit Review:

Scope QAbstractProtobufSerializer::Error enum: Gerrit Review:

Remove todo from QProtobufLazyMessagePointerBase: Gerrit Review:

Remove faulty noexept promises: Gerrit Review:

QProtobufOneof: Inline non-const rawValue: Gerrit Review:

QProtobufRepeatedIterator: Use qt_ptr_swap instead of std::swap: Gerrit Review:

QProtobufOneof: Replace reinterpret_cast with static_cast: Gerrit Review:

QProtobufOneof: Implement move-assignment using QT_MOVE_..._PURE_SWAP: Gerrit Review:

QProtobufMapEntry: Adjust the key() and value() methods return value: Gerrit Review:

Use the scope for QProtobufMapEntry::metaCall: Gerrit Review:

QProtobufLazyMessagePointerBase: Implement move-assignment using QT_MOVE_..._PURE_SWAP: Gerrit Review:

Rid of the QT_DECL_METATYPE_EXTERN_TAGGED for TransparentWrapper types: Gerrit Review:

Fix the detach in the string-enum list converters: Gerrit Review:

QProtobufOneof: Inline non-const rawValue: Gerrit Review:

QProtobufRepeatedIterator: Use qt_ptr_swap instead of std::swap: Gerrit Review:

Make QAbstractProtobufSerializer:(de)serializeMessage private: Gerrit Review:

QProtobufOneof: Replace reinterpret_cast with static_cast: Gerrit Review:

Rid of the QtProtobufPrivate::AbstractRepeatedIterator: Gerrit Review:

Remove todo from QProtobufLazyMessagePointerBase: Gerrit Review:

QProtobufOneof: Implement move-assignment using QT_MOVE_..._PURE_SWAP: Gerrit Review:

Remove faulty noexept promises: Gerrit Review:

Use the scope for QProtobufMapEntry::metaCall: Gerrit Review:

QProtobufLazyMessagePointerBase: Implement move-assignment using QT_MOVE_..._PURE_SWAP: Gerrit Review:

Scope QAbstractProtobufSerializer::Error enum: Gerrit Review:

QProtobufMapEntry: Adjust the key() and value() methods return value: Gerrit Review:

Rid of the QT_DECL_METATYPE_EXTERN_TAGGED for TransparentWrapper types: Gerrit Review:

Fix the detach in the string-enum list converters: Gerrit Review:

Avoid indeterminate initialization of protobuf messages: Gerrit Review:

Rid of the QtProtobufPrivate::AbstractRepeatedIterator: Gerrit Review: