Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-125375

QtGrpc: deadline doesn't respect server response

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.8.0 Beta1, 6.8.0 Beta2
    • 6.8
    • GRPC
    • None
    • 13
    • a07a90509 (dev), 1e24e022e (6.8)
    • Foundation Sprint 108, Foundation Sprint 109

    Description

      It appears to me that our deadline cancellation is not correct:

      auto stream = std::make_shared<QGrpcServerStream>(channelOperation);
    if (auto deadline = deadlineForCall(dPtr->channelOptions, channelOperation->options()))
        QTimer::singleShot(*deadline, stream.get(), &QGrpcServerStream::cancel);

      A deadline should only cancel until the point in time where no server response got delivered.

      Ref: https://grpc.io/docs/guides/deadlines/

      Attachments

        Issue Links

          is required for

          User Story - Created by Jira Software - do not edit or delete. Issue type for a user story. QTBUG-129161 Various enhancements in Qt gRPC and Protobuf

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • In Progress
          For Gerrit Dashboard: QTBUG-125375
          # Subject Branch Project Status CR V
          561812,23 Fix stream cancellation and the deadline timeout dev qt/qtgrpc Status: MERGED +2 0
          565769,2 Fix stream cancellation and the deadline timeout 6.8 qt/qtgrpc Status: MERGED +2 0

          Activity

            People

              dennisoberst Dennis Oberst
              dennisoberst Dennis Oberst
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes