Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-125375

QtGrpc: deadline doesn't respect server response

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P2: Important
    • 6.8.0 Beta1, 6.8.0 Beta2
    • 6.8
    • GRPC
    • None
    • 13
    • a07a90509 (dev), 1e24e022e (6.8)
    • Foundation Sprint 108, Foundation Sprint 109

    Description

      It appears to me that our deadline cancellation is not correct:

      auto stream = std::make_shared<QGrpcServerStream>(channelOperation);
          if (auto deadline = deadlineForCall(dPtr->channelOptions, channelOperation->options()))
              QTimer::singleShot(*deadline, stream.get(), &QGrpcServerStream::cancel);
      

      A deadline should only cancel until the point in time where no server response got delivered.

      Ref: https://grpc.io/docs/guides/deadlines/

      Attachments

        For Gerrit Dashboard: QTBUG-125375
        # Subject Branch Project Status CR V

        Activity

          People

            dennisoberst Dennis Oberst
            dennisoberst Dennis Oberst
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes