Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-125375

QtGrpc: deadline doesn't respect server response

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P2: Important P2: Important
    • 6.8.0 Beta1, 6.8.0 Beta2
    • 6.8
    • GRPC
    • None
    • 13
    • a07a90509 (dev), 1e24e022e (6.8)
    • Foundation Sprint 108, Foundation Sprint 109

      It appears to me that our deadline cancellation is not correct:

      auto stream = std::make_shared<QGrpcServerStream>(channelOperation);
    if (auto deadline = deadlineForCall(dPtr->channelOptions, channelOperation->options()))
        QTimer::singleShot(*deadline, stream.get(), &QGrpcServerStream::cancel);

      A deadline should only cancel until the point in time where no server response got delivered.

      Ref: https://grpc.io/docs/guides/deadlines/

        For Gerrit Dashboard: QTBUG-125375
        # Subject Branch Project Status CR V
        561812,23 Fix stream cancellation and the deadline timeout dev qt/qtgrpc Status: MERGED +2 0
        565769,2 Fix stream cancellation and the deadline timeout 6.8 qt/qtgrpc Status: MERGED +2 0

            dennisoberst Dennis Oberst
            dennisoberst Dennis Oberst
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes