Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126150

QJniArray::const_iterator should be random-access, not just bidirectional

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P1: Critical
    • 6.8.0
    • 6.8.0 FF
    • QPA: Android
    • None
    • Android
    • b5ec0f7a4 (dev), bf97701fd (6.8), d04f38f6f (dev), c4e406e37 (dev), e4b2d7607 (dev), 46ed4e47d (6.8), 0db64ca53 (6.8), d9c38b66a (6.8)

    Description

      QJniArray has op[n], but it's const_iterator claims to be only bidirectional, not random access.

      Acceptance criteria:

      • implement the missing operations on QJniArrayIterator for random-access
      • mark QJniArrayIterator's iterator_category as random_access_iterator_tag
      • update documentation
      • adjust tests

      See https://codereview.qt-project.org/c/qt/qtbase/+/527219/9/src/corelib/tools/qversionnumber.h#194 for a minimal random-access iterator.

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            vhilshei Volker Hilsheimer
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes