Details
-
Bug
-
Resolution: Fixed
-
P1: Critical
-
6.8.0 FF
-
None
-
Android
-
b5ec0f7a4 (dev), bf97701fd (6.8), d04f38f6f (dev), c4e406e37 (dev), e4b2d7607 (dev), 46ed4e47d (6.8), 0db64ca53 (6.8), d9c38b66a (6.8)
Description
QJniArray has op[n], but it's const_iterator claims to be only bidirectional, not random access.
Acceptance criteria:
- implement the missing operations on QJniArrayIterator for random-access
- mark QJniArrayIterator's iterator_category as random_access_iterator_tag
- update documentation
- adjust tests
See https://codereview.qt-project.org/c/qt/qtbase/+/527219/9/src/corelib/tools/qversionnumber.h#194 for a minimal random-access iterator.
Attachments
| For Gerrit Dashboard: QTBUG-126150 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 570947,2 | QJniArray: use comparison macros | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 570948,2 | QJniArray: make iterator strongly ordered | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 570949,2 | QJniArray: add arithmetic operators | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 570950,3 | QJniArray: implement offset dereference operator | dev | qt/qtbase | Status: MERGED | +2 | +1 |
| 574582,2 | QJniArray: use comparison macros | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 575492,3 | QJniArray: make iterator strongly ordered | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 575495,3 | QJniArray: add arithmetic operators | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 575497,3 | QJniArray: implement offset dereference operator | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |