Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126219

Subject private headers to headersclean [QtCore]

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • Build System: CMake, Core: Other
    • None
    • 13
    • b58d92609 (dev), d908c6162 (6.8), 962539d12 (dev), a9404e996 (6.7), 58bd97cb4 (tqtc/lts-6.5), 434ea4401 (dev), fc15cce00 (tqtc/lts-6.2), 5efc98981 (6.8), 2085fdcc7 (tqtc/lts-5.15), e3bfc1a2e (dev), d991cc703 (6.7), c38e58dcb (dev), 1d163e916 (dev)
    • Foundation PM Prioritized, Foundation Sprint 109, Foundation Sprint 110, Foundation Sprint 111, Foundation Sprint 112, Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115, Foundation Sprint 116, Foundation Sprint 117, Foundation Sprint 118, Foundation Sprint 119, Foundation Sprint 120, Foundation Sprint 121, Foundation Sprint 122, Foundation Sprint 123, Foundation Sprint 124

    Description

      Now that -Wweak-vtables is part of headerclean_check, we should also subject private headers to it. This should then catch all the weak vtables that matter (are accessible from other modules, causing duplication).

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. QTBUG-128892 Subject private headers to headersclean [QtDeclarative]

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          is blocked by

          Task - A task that needs to be done. QTBUG-128930 Fix corelib/{text,time}/*_data_p.h static constexpr table anti-pattern

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is cloned by

          Task - A task that needs to be done. QTBUG-129594 Subject private headers to headersclean [QtBase EX Core]

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are no open Gerrit changes