Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126219

Subject private headers to headersclean [QtCore]

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P3: Somewhat important
    • None
    • None
    • Build System: CMake, Core: Other
    • None
    • 13
    • b58d92609 (dev), d908c6162 (6.8), 962539d12 (dev), a9404e996 (6.7), 58bd97cb4 (tqtc/lts-6.5), 434ea4401 (dev), fc15cce00 (tqtc/lts-6.2), 5efc98981 (6.8), 2085fdcc7 (tqtc/lts-5.15), e3bfc1a2e (dev), d991cc703 (6.7), c38e58dcb (dev), 1d163e916 (dev)
    • Foundation PM Prioritized, Foundation Sprint 109, Foundation Sprint 110, Foundation Sprint 111, Foundation Sprint 112, Foundation Sprint 113, Foundation Sprint 114, Foundation Sprint 115, Foundation Sprint 116, Foundation Sprint 117, Foundation Sprint 118, Foundation Sprint 119, Foundation Sprint 120, Foundation Sprint 121, Foundation Sprint 122, Foundation Sprint 123, Foundation Sprint 124

    Description

      Now that -Wweak-vtables is part of headerclean_check, we should also subject private headers to it. This should then catch all the weak vtables that matter (are accessible from other modules, causing duplication).

      Attachments

        Issue Links

          blocks

          Task - A task that needs to be done. QTBUG-128892 Subject private headers to headersclean [QtDeclarative]

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          is blocked by

          Task - A task that needs to be done. QTBUG-128930 Fix corelib/{text,time}/*_data_p.h static constexpr table anti-pattern

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          is cloned by

          Task - A task that needs to be done. QTBUG-129594 Subject private headers to headersclean [QtBase EX Core]

          • P3: Somewhat important - Should be fixed, but doesn't affect the release in any way.
          • Open
          For Gerrit Dashboard: QTBUG-126219
          # Subject Branch Project Status CR V
          590821,3 WIP: Subject _p.h to headerscheck dev qt/qtbase Status: NEW -2 0
          591874,2 Move MetaObjectFlags to namespace QtMocConstants dev qt/qtbase Status: NEW -1 0
          567529,3 Prepare for Q{AbstractAnimation,Unified}Timer::runningAnimationCount() return value change dev qt/qtdeclarative Status: MERGED +2 0
          567558,2 Q{AbstractAnimation,Unified}Timer: Port runningAnimationCount() to qsizetype dev qt/qtbase Status: MERGED +2 0
          567581,3 Fix return type of _q_futex() dev qt/qtbase Status: MERGED +2 0
          567582,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include dev qt/qtbase Status: MERGED +2 0
          567886,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include 6.8 qt/qtbase Status: MERGED +2 0
          568147,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include 6.7 qt/qtbase Status: MERGED +2 0
          568177,2 Fix return type of _q_futex() 6.8 qt/qtbase Status: MERGED +2 0
          568191,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          568255,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          568463,2 qfuturewatcher_p.h: fix missing qfuturewatcher.h include tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          568510,2 Fix return type of _q_futex() 6.7 qt/qtbase Status: MERGED +2 0
          590800,2 QtCore: fix private header compilation under QT_NO_KEYWORDS dev qt/qtbase Status: MERGED +2 0
          590801,2 QBindingObserverPtr: fix redundant ; dev qt/qtbase Status: MERGED +2 0
          590802,2 QDuplicateTracker: fix redundant ; dev qt/qtbase Status: MERGED +2 0
          590804,2 Fix -Wdouble-promotion in FP overload of convertDoubleTo() dev qt/qtbase Status: MERGED +2 0
          590820,4 QtCore: De-duplicate vtables, 2024 edition dev qt/qtbase Status: MERGED +2 0
          590978,2 QtCore: fix private header compilation under QT_NO_KEYWORDS 6.8 qt/qtbase Status: MERGED +2 0
          590979,2 QBindingObserverPtr: fix redundant ; 6.8 qt/qtbase Status: MERGED +2 0
          590980,2 QDuplicateTracker: fix redundant ; 6.8 qt/qtbase Status: MERGED +2 0
          590982,2 Fix -Wdouble-promotion in FP overload of convertDoubleTo() 6.8 qt/qtbase Status: MERGED +2 0
          591036,2 QBindingObserverPtr: fix redundant ; 6.7 qt/qtbase Status: MERGED +2 0
          591037,2 QDuplicateTracker: fix redundant ; 6.7 qt/qtbase Status: MERGED +2 0
          591039,3 Fix -Wdouble-promotion in FP overload of convertDoubleTo() 6.7 qt/qtbase Status: MERGED +2 0
          591123,2 QtCore: De-duplicate vtables, 2024 edition 6.8 qt/qtbase Status: MERGED +2 0
          591125,2 QBindingObserverPtr: fix redundant ; tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591126,2 QDuplicateTracker: fix redundant ; tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591196,2 corelib/time: fix (easy) -Wunused-const-variable warnings in _p.h's dev qt/qtbase Status: MERGED +2 0
          591197,2 QPropertyBindingPrivate: prevent -Wshadow in qqmlpropertybinding_p.h dev qt/qtbase Status: MERGED +2 0
          591198,3 qendian_p.h: fix -Wshadow warning dev qt/qtbase Status: MERGED +2 0
          591214,4 qstorageinfo_p.h: fix -Wunused-function dev qt/qtbase Status: MERGED +2 0
          591216,2 qsavefile_p.h: fix missing qsavefile.h include dev qt/qtbase Status: MERGED +2 0
          591229,3 qtipccommon_p.h: fix -Wunused-function dev qt/qtbase Status: MERGED +2 0
          591234,2 QSharedMemoryPrivate: fix -Wshadow in create() dev qt/qtbase Status: MERGED +2 0
          591348,2 qlocale_tools_p.h: fix -Wfloat-equal dev qt/qtbase Status: MERGED +2 0
          591393,3 qxmlstreamparser_p.h: fix -Wshadow in parse() dev qt/qtbase Status: MERGED +2 0
          591406,3 Change QTimeZonePrivate::invalidSeconds() return type from qint64 to int dev qt/qtbase Status: MERGED +2 0
          591417,3 qwaitcondition_p.h: fix -Wunused-const-variable dev qt/qtbase Status: MERGED +2 0
          591432,2 Fix -Wdouble-promotion in FP overload of convertDoubleTo() tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591433,3 QBindingObserverPtr: fix redundant ; tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          591434,2 QDuplicateTracker: fix redundant ; tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          591436,2 QPropertyBindingPrivate: prevent -Wshadow in qqmlpropertybinding_p.h 6.8 qt/qtbase Status: MERGED +2 0
          591437,2 qsavefile_p.h: fix missing qsavefile.h include 6.8 qt/qtbase Status: MERGED +2 0
          591439,2 qtipccommon_p.h: fix -Wunused-function 6.8 qt/qtbase Status: MERGED +2 0
          591455,3 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier dev qt/qtbase Status: MERGED +2 0
          591456,4 De-inline ~QDeviceClosedNotifier dev qt/qtbase Status: MERGED +2 0
          591542,2 QDuplicateTracker: fix redundant ; tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          591545,2 QPropertyBindingPrivate: prevent -Wshadow in qqmlpropertybinding_p.h 6.7 qt/qtbase Status: MERGED +2 0
          591546,2 qsavefile_p.h: fix missing qsavefile.h include 6.7 qt/qtbase Status: MERGED +2 0
          591547,2 qtipccommon_p.h: fix -Wunused-function 6.7 qt/qtbase Status: MERGED +2 0
          591553,2 qlocale_tools_p.h: fix -Wfloat-equal 6.8 qt/qtbase Status: MERGED +2 0
          591555,2 Change QTimeZonePrivate::invalidSeconds() return type from qint64 to int 6.8 qt/qtbase Status: MERGED +2 0
          591607,2 qlocale_tools_p.h: fix -Wfloat-equal 6.7 qt/qtbase Status: MERGED +2 0
          591688,2 qwaitcondition_p.h: fix -Wunused-const-variable 6.8 qt/qtbase Status: MERGED +2 0
          591748,2 qlocale_tools_p.h: fix -Wfloat-equal tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591749,2 QPropertyBindingPrivate: prevent -Wshadow in qqmlpropertybinding_p.h tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591750,2 qsavefile_p.h: fix missing qsavefile.h include tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          591808,6 Inline qcorecmdlineargs_p.h into qcoreapplication.cpp dev qt/qtbase Status: MERGED +2 +1
          591853,2 qwaitcondition_p.h: fix -Wunused-const-variable 6.7 qt/qtbase Status: MERGED +2 0
          591858,2 QPropertyBindingPrivate: prevent -Wshadow in qqmlpropertybinding_p.h tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          591859,3 Fix -Wdouble-promotion in FP overload of convertDoubleTo() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          591860,2 qsavefile_p.h: fix missing qsavefile.h include tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          591952,2 corelib/time: fix (easy) -Wunused-const-variable warnings in _p.h's 6.8 qt/qtbase Status: MERGED +2 0
          591953,2 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier 6.8 qt/qtbase Status: MERGED +2 0
          591954,2 qendian_p.h: fix -Wshadow warning 6.8 qt/qtbase Status: MERGED +2 0
          591955,4 qstorageinfo_p.h: fix -Wunused-function 6.8 qt/qtbase Status: MERGED +2 +1
          591972,2 qsavefile_p.h: fix missing qsavefile.h include tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          591978,2 De-inline ~QDeviceClosedNotifier 6.8 qt/qtbase Status: MERGED +2 0
          592089,2 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier 6.7 qt/qtbase Status: MERGED +2 0
          592090,2 corelib/time: fix (easy) -Wunused-const-variable warnings in _p.h's 6.7 qt/qtbase Status: MERGED +2 0
          592091,2 qendian_p.h: fix -Wshadow warning 6.7 qt/qtbase Status: MERGED +2 0
          592180,2 Fix -Wdouble-promotion in FP overload of convertDoubleTo() tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          592391,2 QtPrivate::CurrentCompatPropertyThief: port to QScopedValueRollback dev qt/qtbase Status: MERGED +2 0
          592392,2 QPropertyBindingPrivate: fix -Wshadow in sourceLocation() dev qt/qtbase Status: MERGED +2 0
          592481,3 Suppress -Woverloaded-virtual in QAbstractEventDispatcherV2 hierarchy dev qt/qtbase Status: MERGED +2 0
          592727,2 QtPrivate::CurrentCompatPropertyThief: port to QScopedValueRollback 6.8 qt/qtbase Status: MERGED +2 0
          592728,2 Inline qcorecmdlineargs_p.h into qcoreapplication.cpp 6.8 qt/qtbase Status: MERGED +2 0
          592729,2 QPropertyBindingPrivate: fix -Wshadow in sourceLocation() 6.8 qt/qtbase Status: MERGED +2 0
          592747,2 QtPrivate::CurrentCompatPropertyThief: port to QScopedValueRollback 6.7 qt/qtbase Status: MERGED +2 0
          592749,2 QPropertyBindingPrivate: fix -Wshadow in sourceLocation() 6.7 qt/qtbase Status: MERGED +2 0
          593498,2 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          593499,2 qendian_p.h: fix -Wshadow warning tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          593500,2 QtPrivate::CurrentCompatPropertyThief: port to QScopedValueRollback tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          593501,3 corelib/time: fix (easy) -Wunused-const-variable warnings in _p.h's tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          593502,2 QPropertyBindingPrivate: fix -Wshadow in sourceLocation() tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          593710,2 QtPrivate::CurrentCompatPropertyThief: port to QScopedValueRollback tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          593711,2 qendian_p.h: fix -Wshadow warning tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          593712,3 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          593713,2 QPropertyBindingPrivate: fix -Wshadow in sourceLocation() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          593759,3 qendian_p.h: fix -Wshadow warning tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          594380,1 qstorageinfo_p.h: fix -Wunused-function 6.7 qt/qtbase Status: MERGED +2 0
          594886,2 qtextstream_p.h: fix -Wshadow in QDeviceClosedNotifier tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          596313,2 qxmlstreamparser_p.h: fix -Wshadow in parse() 6.8 qt/qtbase Status: MERGED +2 0
          596314,2 QSharedMemoryPrivate: fix -Wshadow in create() 6.8 qt/qtbase Status: MERGED +2 0
          597251,2 qxmlstreamparser_p.h: fix -Wshadow in parse() tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
          597295,4 qxmlstreamparser_p.h: fix -Wshadow in parse() tqtc/lts-6.2 qt/tqtc-qtbase Status: MERGED +2 0
          598334,3 qxmlstreamparser_p.h: fix -Wshadow in parse() tqtc/lts-5.15 qt/tqtc-qtbase Status: MERGED +2 0
          605178,2 Suppress -Woverloaded-virtual in QAbstractEventDispatcherV2 hierarchy 6.8 qt/qtbase Status: MERGED +2 0

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Gerrit Reviews

                  There are 2 open Gerrit changes