Details
-
Technical task
-
Resolution: Unresolved
-
P2: Important
-
None
-
None
-
316534e6c (dev), f3c4df656 (6.8), 4745a53ce (6.7), 92c9d1fd1 (dev), c4a870685 (dev), 9e0aa6692 (6.8), 8011361b6 (6.8), d7fe12f0d (6.7), b53429f24 (6.7)
Description
https://doc-snapshots.qt.io/qt6-dev/qt-add-protobuf.html
https://doc-snapshots.qt.io/qt6-dev/qtprotobufgen-qt-tool.html
*Action points:*
AP: Update doc string for `EXTRA_NAMESPACE` -> https://codereview.qt-project.org/c/qt/qtgrpc/+/568819
AP: Re-arrange snippets and recheck regarding QML_URI whether it is required
AP: Check if `QML_URI` issues warning if target already exists, rephrase as appropriate -> The explanation is in the text. The snippet was not at the right place, though.
AP: Mention the .proto file names beforehand in the `Resolving dependencies between protobuf targets` doc section
AP: Consider simplifying / rephrasing the PUBLIC link blue not in the same section
Attachments
Gerrit Reviews
| For Gerrit Dashboard: QTBUG-126472 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 570652,2 | Move the qt_add_protobuf QML related snippets | dev | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 570653,2 | Mention the .proto file names in 'Resolving dependencies...' section | dev | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 570654,4 | Rework the 'PUBLIC linking' bluenote rationale | dev | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 570762,2 | Mention the .proto file names in 'Resolving dependencies...' section | 6.8 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 570968,2 | Mention the .proto file names in 'Resolving dependencies...' section | 6.7 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573514,2 | Move the qt_add_protobuf QML related snippets | 6.8 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573515,2 | Rework the 'PUBLIC linking' bluenote rationale | 6.8 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573693,2 | Move the qt_add_protobuf QML related snippets | 6.7 | qt/qtgrpc | Status: MERGED | +2 | 0 |
| 573694,2 | Rework the 'PUBLIC linking' bluenote rationale | 6.7 | qt/qtgrpc | Status: MERGED | +2 | 0 |