Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-126459 CMake API Review for Qt 6.8
  3. QTBUG-126472

Address Qt 6.8 CMake API review notes for qtprotobuf

    XMLWordPrintable

Details

    • 316534e6c (dev), f3c4df656 (6.8), 4745a53ce (6.7), 92c9d1fd1 (dev), c4a870685 (dev), 9e0aa6692 (6.8), 8011361b6 (6.8), d7fe12f0d (6.7), b53429f24 (6.7)

    Description

      https://doc-snapshots.qt.io/qt6-dev/qt-add-protobuf.html

      https://doc-snapshots.qt.io/qt6-dev/qtprotobufgen-qt-tool.html

      *Action points:*
      AP: Update doc string for `EXTRA_NAMESPACE` -> https://codereview.qt-project.org/c/qt/qtgrpc/+/568819
      AP: Re-arrange snippets and recheck regarding QML_URI whether it is required
      AP: Check if `QML_URI` issues warning if target already exists, rephrase as appropriate -> The explanation is in the text. The snippet was not at the right place, though.
      AP: Mention the .proto file names beforehand in the `Resolving dependencies between protobuf targets` doc section
      AP: Consider simplifying / rephrasing the PUBLIC link blue not in the same section

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            qtbuildsystem Qt Build System Team
            alexandru.croitor Alexandru Croitor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: