Details
-
Task
-
Resolution: Fixed
-
P2: Important
-
None
-
None
-
13
-
0988042c4 (dev), 8189baf26 (6.8), 2fa59f025 (dev), e17d336a2 (6.8), 322e0ad32 (6.7), 96c07655c (dev), 58ddd0ac3 (dev), d802d268d (6.8), 5c1f32a3b (tqtc/lts-6.5), 5079925f2 (tqtc/lts-6.2), ce5df62c8 (6.7), fd7fb0bb4 (tqtc/lts-6.5), 86a90ec07 (tqtc/lts-6.2)
-
Foundation Sprint 116, Foundation Sprint 117, Foundation Sprint 118, Foundation Sprint 119
Description
Clang warns (correctly):
corelib/time/qjalalicalendar_data_p.h:39:34: error: unused variable 'locale_data' [-Werror,-Wunused-const-variable] static constexpr QCalendarLocale locale_data[] = { ^ corelib/time/qjalalicalendar_data_p.h:717:27: error: unused variable 'months_data' [-Werror,-Wunused-const-variable] static constexpr char16_t months_data[] = {
(etc)
Header files (*.h) are supposed to be robust against being included in multiple TUs, but these headers will re-define their constexpr tables in each TU they're included in, duplicating them every time.
Suggest to rename to .cpp and include from other .cpp's.
Attachments
Issue Links
- blocks
-
-
- Open
-
-
-
- Open
-
| For Gerrit Dashboard: QTBUG-128930 | ||||||
|---|---|---|---|---|---|---|
| # | Subject | Branch | Project | Status | CR | V |
| 591224,2 | Suppress -Wunused-const-variable in _data_p.h files | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 591438,3 | Suppress -Wunused-const-variable in _data_p.h files | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 592105,3 | Remove unneeded and improper #include | dev | qt/qtdeclarative | Status: MERGED | +2 | +1 |
| 592194,3 | Remove spurious #include from QJulianCalendar's implementation | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 592195,4 | Remove a duplicate inclusion of qlocale_data_p.h | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 592657,2 | Remove unneeded and improper #include | 6.8 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
| 592687,2 | Remove unneeded and improper #include | 6.7 | qt/qtdeclarative | Status: MERGED | +2 | 0 |
| 592964,2 | Remove unneeded and improper #include | tqtc/lts-6.5 | qt/tqtc-qtdeclarative | Status: MERGED | +2 | 0 |
| 593090,2 | Remove spurious #include from QJulianCalendar's implementation | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 593091,6 | Remove a duplicate inclusion of qlocale_data_p.h | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |
| 593108,2 | Remove spurious #include from QJulianCalendar's implementation | 6.7 | qt/qtbase | Status: MERGED | +2 | 0 |
| 593218,2 | Remove unneeded and improper #include | tqtc/lts-6.2 | qt/tqtc-qtdeclarative | Status: MERGED | +2 | 0 |
| 593749,2 | Remove spurious #include from QJulianCalendar's implementation | tqtc/lts-6.5 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 593789,2 | Remove spurious #include from QJulianCalendar's implementation | tqtc/lts-6.2 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 597492,3 | Remove a duplicate inclusion of qlocale_data_p.h | tqtc/lts-6.5 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 598713,1 | Disentangle qlocale_data_p.h from qtimezonelocale.cpp | dev | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 598714,1 | Disentangle qtimezone{private,locale}_data_p.h access | dev | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 598715,2 | Placate headersclean by turning *_data_p.h into *_data.inc | dev | qt/qtbase | Status: ABANDONED | 0 | 0 |
| 599378,4 | Remove a duplicate inclusion of qlocale_data_p.h | tqtc/lts-6.2 | qt/tqtc-qtbase | Status: MERGED | +2 | 0 |
| 600519,3 | Make static constexpr data tables inline in corelib/t*/q*_data_p.h | dev | qt/qtbase | Status: MERGED | +2 | 0 |
| 600522,5 | Exclude q*_data_p.h files from the generated include/ | dev | qt/qtbase | Status: MERGED | +2 | +1 |
| 600962,4 | Make static constexpr data tables inline in corelib/t*/q*_data_p.h | 6.8 | qt/qtbase | Status: MERGED | +2 | 0 |