Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138583

QLocale::toUpper() is not 64-bit-safe on ICU

XMLWordPrintable

    • 13
    • 816f4dfd2 (6.9), 814624948 (6.9), f1c3af04a (dev), cd64c8080 (6.10), 02ed0c776 (6.9), d1dfd8a62 (tqtc/lts-6.8), 37ba54cfb (tqtc/lts-6.8), 4b5ac7283 (tqtc/lts-6.8), d409c3d26 (tqtc/lts-6.5), 29fc48893 (tqtc/lts-6.5), 2e24a8d61 (tqtc/lts-6.5)
    • Foundation Sprint 134, Foundation Sprint 135, Foundation Sprint 136, Foundation Sprint 137, Foundation Sprint 138

      The code simply assumes that it can stuff QString::size() into an int32_t and even add 25% on top. In reality, this truncates, with potentially nasty consequences, depending on how ICU handles things.

        For Gerrit Dashboard: QTBUG-138583
        # Subject Branch Project Status CR V
        663066,2 QStringIterator: long live resync{Forward,Backward}()! dev qt/qtbase Status: NEW +1 0
        663062,2 QLocale/ICU: don't take addresses of ICU functions dev qt/qtbase Status: MERGED +2 0
        663063,3 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts dev qt/qtbase Status: MERGED +2 0
        663065,3 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences dev qt/qtbase Status: MERGED +2 0
        663068,2 QLocale/ICU: work around 32-bit limitation of toUpper/Lower() dev qt/qtbase Status: DEFERRED -1 +1
        663069,2 QLocale/ICU: increase the toUpper/Lower chunk size to INT_MAX/4 dev qt/qtbase Status: DEFERRED 0 0
        663612,2 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences 6.10 qt/qtbase Status: MERGED +2 0
        663711,2 QLocale/ICU: don't take addresses of ICU functions 6.10 qt/qtbase Status: MERGED +2 0
        663717,2 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences 6.9 qt/qtbase Status: MERGED +2 0
        663775,2 QLocale/ICU: don't take addresses of ICU functions 6.9 qt/qtbase Status: MERGED +2 0
        663782,3 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0
        663785,3 QLocale/ICU: don't take addresses of ICU functions tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0
        664091,2 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts 6.10 qt/qtbase Status: MERGED +2 0
        664153,2 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts 6.9 qt/qtbase Status: MERGED +2 0
        664355,3 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts tqtc/lts-6.8 qt/tqtc-qtbase Status: MERGED +2 0
        669796,2 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
        669797,2 QLocale/ICU: don't take addresses of ICU functions tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0
        669896,2 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts tqtc/lts-6.5 qt/tqtc-qtbase Status: MERGED +2 0

            mmutz Marc Mutz
            mmutz Marc Mutz
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                There is 1 open Gerrit change