Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138583

QLocale::toUpper() is not 64-bit-safe on ICU

    XMLWordPrintable

Details

    • 13
    • 4806a5a85 (dev), 6f4d64b21 (dev), ea092bd76 (6.10), cd3e0bdb5 (6.10), 816f4dfd2 (6.9), 814624948 (6.9), f1c3af04a (dev), cd64c8080 (6.10), 02ed0c776 (6.9)
    • Foundation Sprint 134, Foundation Sprint 135

    Description

      The code simply assumes that it can stuff QString::size() into an int32_t and even add 25% on top. In reality, this truncates, with potentially nasty consequences, depending on how ICU handles things.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-138630 QLocale::toUpper() is not 64-bit-safe on Windows

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Reported
          resulted from

          Task - A task that needs to be done. QTBUG-135195 Review qtbase/src/corelib/text

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; Flaky tests; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • In Progress
          For Gerrit Dashboard: QTBUG-138583
          # Subject Branch Project Status CR V
          663066,2 QStringIterator: long live resync{Forward,Backward}()! dev qt/qtbase Status: NEW 0 0
          663068,2 QLocale/ICU: work around 32-bit limitation of toUpper/Lower() dev qt/qtbase Status: NEW -1 +1
          663069,2 QLocale/ICU: increase the toUpper/Lower chunk size to INT_MAX/4 dev qt/qtbase Status: NEW 0 0
          663782,2 tst_QLocale::toLowerUpper(): also test long Türkiye ı,İ sequences tqtc/lts-6.8 qt/tqtc-qtbase Status: NEW +1 0
          663785,2 QLocale/ICU: don't take addresses of ICU functions tqtc/lts-6.8 qt/tqtc-qtbase Status: NEW +1 0
          664355,2 QLocale/ICU: static_assert(is_same<UChar,char16_t>) and remove casts tqtc/lts-6.8 qt/tqtc-qtbase Status: NEW +1 0

          Activity

            People

              mmutz Marc Mutz
              mmutz Marc Mutz
              Vladimir Minenko Vladimir Minenko
              Alex Blasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: