Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138712

[CMake] Ensure that we don't publicly depend on private modules

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • None
    • None
    • Build System: CMake
    • None
    • a070449a4 (dev), 5571a1e37 (dev), 26a5ebde0 (dev), 487585b12 (dev), 9504ad7dc (6.10), 2dd619c39 (6.10), 17b1b9cee (6.10), d6ebfaa75 (6.10), b83857165 (dev), 5f1d94ba6 (6.10)

      https://codereview.qt-project.org/c/qt/qtbase/+/663438 fixed the ExamplesAssetDownloaderPrivate module...

      ...but I found another instance in the Quick3DHelpers module: https://github.com/qt/qtquick3d/blob/v6.10.0-beta2/src/helpers/CMakeLists.txt#L50-L54

       

      Suggestion

      1. Create an automated way to prevent any such instances from being accidentally introduced in the future (Gerrit's Sanity Bot?)
      2. Comb through and fix every existing module (ideally with the automated help)

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            qtbuildsystem Qt Build System Team
            skoh-qt Sze Howe Koh
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: