Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-138712

[CMake] Ensure that we don't publicly depend on private modules

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • None
    • None
    • Build System: CMake
    • None
    • a070449a4 (dev), 5571a1e37 (dev), 26a5ebde0 (dev), 487585b12 (dev), 9504ad7dc (6.10), 2dd619c39 (6.10), 17b1b9cee (6.10), d6ebfaa75 (6.10), b83857165 (dev), 5f1d94ba6 (6.10)

      https://codereview.qt-project.org/c/qt/qtbase/+/663438 fixed the ExamplesAssetDownloaderPrivate module...

      ...but I found another instance in the Quick3DHelpers module: https://github.com/qt/qtquick3d/blob/v6.10.0-beta2/src/helpers/CMakeLists.txt#L50-L54

       

      Suggestion

      1. Create an automated way to prevent any such instances from being accidentally introduced in the future (Gerrit's Sanity Bot?)
      2. Comb through and fix every existing module (ideally with the automated help)

        For Gerrit Dashboard: QTBUG-138712
        # Subject Branch Project Status CR V
        663940,4 CMake: Warn about public modules linking to private modules publicly dev qt/qtbase Status: MERGED +2 0
        663941,7 CMake: Don't publicly propagate private Qt modules for public modules dev qt/qtdeclarative Status: MERGED +2 0
        663942,5 CMake: Don't publicly propagate private Qt modules for public modules dev qt/qtquick3d Status: MERGED +2 0
        663946,6 CMake: Don't publicly propagate private Qt modules for public modules dev qt/qtlocation Status: MERGED +2 0
        663947,5 CMake: Don't publicly propagate private Qt modules for public modules dev qt/tqtc-qtinsighttracker Status: MERGED +2 +1
        664396,2 CMake: Don't publicly propagate private Qt modules for public modules 6.10 qt/tqtc-qtinsighttracker Status: MERGED +2 0
        664397,2 CMake: Don't publicly propagate private Qt modules for public modules 6.10 qt/qtlocation Status: MERGED +2 0
        664409,2 CMake: Don't publicly propagate private Qt modules for public modules 6.10 qt/qtquick3d Status: MERGED +2 0
        664445,2 CMake: Don't publicly propagate private Qt modules for public modules 6.10 qt/qtdeclarative Status: MERGED +2 0
        664969,2 CMake: Warn about public modules linking to private modules publicly 6.10 qt/qtbase Status: MERGED +2 0

            qtbuildsystem Qt Build System Team
            skoh-qt Sze Howe Koh
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: