Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25067

Qt 5 to-do's in QPixmap

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.0.0 Beta 1
    • Component/s: Image formats
    • Labels:
      None
    • Technical Risk:
      Normal
    • Commits:
      f13acef7ba7ba48c6d4a057636dca8ddb85a72cd

      Description

      The QPixmnap code contains four Qt 5 to-do comments:

      qpixmap.cpp
      QPixmap QPixmap::grabWidget(QObject *widget, const QRect &rectangle)
      {
          QPixmap pixmap;
          // ### Qt5: should we keep or remove this method?
          // SC solution would be to install a callback form QtWidgets, but ugly.
          qWarning("QPixmap::grabWidget is deprecated, use QWidget::grab() instead");
          if (!widget)
              return pixmap;
          QMetaObject::invokeMethod(widget, "grab", Qt::DirectConnection,
                                    Q_RETURN_ARG(QPixmap, pixmap),
                                    Q_ARG(QRect, rectangle));
          return pixmap;
      }
      
      qpixmap.h
          bool isNull() const; // ### Qt 5: make inline
      ...
          int width() const; // ### Qt 5: make inline
          int height() const; // ### Qt 5: make inline
      

      These comments should either be actioned for Qt 5 (while preserving source-compatibility), removed, or changed to Qt 6 to-do's.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              kkalland Kim Motoyoshi Kalland (Inactive)
              Reporter:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes