Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-20885 Larger changes for Qt 5
  3. QTBUG-23524

[API] Grep the source for Qt5 todo items

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Fix Version/s: 5.0.0 Beta 1, 5.0.0
    • Component/s: None
    • Labels:
      None
    • Technical Risk:
      Normal

      Description

      There is a lot of output from the command

      git grep -i "qt\s*5"

      which need to be actioned for Qt5.

      Additionally, some items which should be actioned for Qt5 are not commented with the string 'Qt5', but only '###', so that needs to be grepped too.

      Additionally, there are some items which are commented as should be changed after Qt 4.x.

      An incomplete list of indicative examples:

      src/corelib/kernel/qobjectcleanuphandler.h
      private:
      // ### move into d pointer
      QObjectList cleanupObjects;

      corelib/statemachine/qstatemachine.cpp:// ### in Qt 4.6 we can use QObject::senderSignalIndex()
      widgets/styles/qstyle.cpp: // ### Qt 4.1: invokeMethod should accept const functions, to avoid this dirty cast

      widgets/kernel/qwidget.cpp: // ### Fix properly for 4.3
      widgets/kernel/qwidget.cpp: // ### createWinId() ??
      widgets/kernel/qwidget_p.h: // ### Qt 4.6: Merge into a template function (after MSVC isn't supported anymore).

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Reporter:
              stephen.kelly Stephen Kelly (Unused account) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes