Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25088

Qt 5 to-do's in QFileSystemModel

    XMLWordPrintable

    Details

    • Technical Risk:
      Normal
    • Commits:
      94519a441cf1ea77f1422c44a7ef8ec15171ad04

      Description

      The QFileSystemModel code contains three Qt 5 to-do comments:

      qtbase/src/widgets/dialogs/qfilesystemmodel.cpp
          // Note that we match the behavior of entryList and not QFileInfo on this and this
          // incompatibility won't be fixed until Qt 5 at least
          bool isDot    = (node->fileName == QLatin1String("."));
          bool isDotDot = (node->fileName == QLatin1String(".."));
          if (   (hideHidden && !(isDot || isDotDot) && node->isHidden())
              || (hideSystem && node->isSystem())
              || (hideDirs && node->isDir())
              || (hideFiles && node->isFile())
              || (hideSymlinks && node->isSymLink())
              || (hideReadable && node->isReadable())
              || (hideWritable && node->isWritable())
              || (hideExecutable && node->isExecutable())
              || (hideDot && isDot)
              || (hideDotDot && isDotDot))
              return false;
      
      qtbase/src/widgets/dialogs/qfilesystemmodel.h
          bool rmdir(const QModelIndex &index) const; // ### Qt5: should not be const
      
      qtbase/src/widgets/dialogs/qfilesystemmodel_p.h
          // ### Qt 5: resolvedSymLinks goes away
          QHash<QString, QString> resolvedSymLinks;
      

      Any of these that can be handled without breaking source-compatibility should be actioned for Qt 5.0.0. Any others should be removed or changed to Qt 6 to-do's.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Reporter:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes