Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
94519a441cf1ea77f1422c44a7ef8ec15171ad04
Description
The QFileSystemModel code contains three Qt 5 to-do comments:
qtbase/src/widgets/dialogs/qfilesystemmodel.cpp
// Note that we match the behavior of entryList and not QFileInfo on this and this // incompatibility won't be fixed until Qt 5 at least bool isDot = (node->fileName == QLatin1String(".")); bool isDotDot = (node->fileName == QLatin1String("..")); if ( (hideHidden && !(isDot || isDotDot) && node->isHidden()) || (hideSystem && node->isSystem()) || (hideDirs && node->isDir()) || (hideFiles && node->isFile()) || (hideSymlinks && node->isSymLink()) || (hideReadable && node->isReadable()) || (hideWritable && node->isWritable()) || (hideExecutable && node->isExecutable()) || (hideDot && isDot) || (hideDotDot && isDotDot)) return false;
qtbase/src/widgets/dialogs/qfilesystemmodel.h
bool rmdir(const QModelIndex &index) const; // ### Qt5: should not be const
qtbase/src/widgets/dialogs/qfilesystemmodel_p.h
// ### Qt 5: resolvedSymLinks goes away
QHash<QString, QString> resolvedSymLinks;
Any of these that can be handled without breaking source-compatibility should be actioned for Qt 5.0.0. Any others should be removed or changed to Qt 6 to-do's.
Attachments
Issue Links
- resulted from
-
QTBUG-23524 [API] Grep the source for Qt5 todo items
- Closed
For Gerrit Dashboard: QTBUG-25088 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
22895,1 | Address Qt 5 to-do comments related to QFileSystemModel. | api_changes | qt/qtbase | Status: MERGED | +2 | 0 |