Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25068

Qt 5 to-do in qpalette.h

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.0.0 Beta 1
    • Component/s: GUI: Painting
    • Labels:
      None
    • Technical Risk:
      Normal
    • Commits:
      73496630fe64b3d813480dc852000edaa3acf47b

      Description

      qtbase/src/gui/kernel/qpalette.h contains three Qt 5 to-do comments on the ColorRole enum:

      qpallette.h
          enum ColorRole { WindowText, Button, Light, Midlight, Dark, Mid,
                           Text, BrightText, ButtonText, Base, Window, Shadow,
                           Highlight, HighlightedText,
                           Link, LinkVisited, // ### Qt 5: remove
                           AlternateBase,
                           NoRole, // ### Qt 5: value should be 0 or -1
                           ToolTipBase, ToolTipText,
                           NColorRoles = ToolTipText + 1,
                           Foreground = WindowText, Background = Window // ### Qt 5: remove
                         };
      

      These comments should either be actioned for Qt 5.0.0, removed, or changed to Qt 6 to-do's. (It appears that the first and third comments cannot be done for 5.0.0 as source-incompatible changes are no longer permitted).

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              rodal Samuel Rødal
              Reporter:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes