Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25103

Qt 5 to-do's in QDom

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.0.0 Beta 1
    • Component/s: XML: DOM
    • Labels:
      None
    • Technical Risk:
      Normal
    • Commits:
      7ff5fb610c665d8aa5eb5be431e96540caeb75ef

      Description

      qtbase/src/xml/dom/qdom.cpp
      /*
        ### old todo comments -- I don't know if they still apply...
      
        If the document dies, remove all pointers to it from children
        which can not be deleted at this time.
      
        If a node dies and has direct children which can not be deleted,
        then remove the pointer to the parent.
      
        createElement and friends create double reference counts.
      */
      
      /* ##### new TODOs:
      
        Remove emtpy emthods in the *Private classes
      
        Make a lot of the (mostly empty) methods in the public classes inline.
        Specially constructors assignment operators and comparison operators are candidates.
      */
      ...
             /** ### Qt 5:
               *
               * If we still have QDom, optimize this so that we only declare namespaces that are not
               * yet declared. We loose default namespace mappings, so maybe we should rather store
               * the information that we get from startPrefixMapping()/endPrefixMapping() and use them.
               * Modifications becomes more complex then, however.
               *
               * We cannot do this during the Qt 4 series because it would require too invasive changes, and
               * hence possibly behavioral changes.
               */
      

      Action for Qt 5.0.0 (if source-compatibility can be maintained), remove, or change to Qt 6 to-do's.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Reporter:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes