Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-25091

Qt 5 to-do's in QGraphicsProxyWidget

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: P2: Important
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.0.0 Beta 1
    • Component/s: Widgets: GraphicsView
    • Labels:
      None
    • Technical Risk:
      Normal

      Description

      The QGraphicsProxyWidget code contains several to-do comments for Qt 5:

      src/widgets/graphicsview/qgraphicsproxywidget.cpp
      /*!
          \internal
      
          Reimplemented from QGraphicsItemPrivate. ### Qt 5: Move impl to
          reimplementation QGraphicsProxyWidget::inputMethodQuery().
      */
      QVariant QGraphicsProxyWidgetPrivate::inputMethodQueryHelper(Qt::InputMethodQuery query) const
      ...
          case QEvent::InputMethod: {
              // Forward input method events if the focus widget enables
              // input methods.
              // ### Qt 4.5: this code must also go into a reimplementation
              // of inputMethodEvent().
              QWidget *focusWidget = d->widget->focusWidget();
              if (focusWidget && focusWidget->testAttribute(Qt::WA_InputMethodEnabled))
                  QApplication::sendEvent(focusWidget, event);
              break;
          }
      
      src/widgets/graphicsview/qgraphicsproxywidget.h
          // ### Qt 4.5:
          // QVariant inputMethodQuery(Qt::InputMethodQuery query) const;
          // void inputMethodEvent(QInputMethodEvent *event);
      
      src/widgets/graphicsview/qgraphicsproxywidget_p.h
          // ### Qt 5: Remove. Workaround for reimplementation added after Qt 4.4.
          QVariant inputMethodQueryHelper(Qt::InputMethodQuery query) const;
      

      Those comments that can be handled without breaking source-compatibility should be actioned for Qt 5.0.0. Any others should be removed or changed to Qt 6 to-do's.

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              paeglis Gatis Paeglis
              Reporter:
              jasmcdon Jason McDonald (Closed Nokia Identity. Please assign to "macadder" instead) (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes