Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
Description
The QGraphicsProxyWidget code contains several to-do comments for Qt 5:
src/widgets/graphicsview/qgraphicsproxywidget.cpp
/*! \internal Reimplemented from QGraphicsItemPrivate. ### Qt 5: Move impl to reimplementation QGraphicsProxyWidget::inputMethodQuery(). */ QVariant QGraphicsProxyWidgetPrivate::inputMethodQueryHelper(Qt::InputMethodQuery query) const ... case QEvent::InputMethod: { // Forward input method events if the focus widget enables // input methods. // ### Qt 4.5: this code must also go into a reimplementation // of inputMethodEvent(). QWidget *focusWidget = d->widget->focusWidget(); if (focusWidget && focusWidget->testAttribute(Qt::WA_InputMethodEnabled)) QApplication::sendEvent(focusWidget, event); break; }
src/widgets/graphicsview/qgraphicsproxywidget.h
// ### Qt 4.5: // QVariant inputMethodQuery(Qt::InputMethodQuery query) const; // void inputMethodEvent(QInputMethodEvent *event);
src/widgets/graphicsview/qgraphicsproxywidget_p.h
// ### Qt 5: Remove. Workaround for reimplementation added after Qt 4.4. QVariant inputMethodQueryHelper(Qt::InputMethodQuery query) const;
Those comments that can be handled without breaking source-compatibility should be actioned for Qt 5.0.0. Any others should be removed or changed to Qt 6 to-do's.
Attachments
Issue Links
- resulted from
-
QTBUG-23524 [API] Grep the source for Qt5 todo items
- Closed