Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
-
f2b77e3ff71511944ad8da56cb63c4ca8daf6417
Description
qtbase/src/gui/painting/qpaintengineex_p.h contains the following Qt 5 to-do comment:
qpaintengineex_p.h
// ### Qt5: remove, once QtGui is merged into QtGui and QtWidgets // Return a pixmap filter of "type" that can render the parameters // in "prototype". The returned filter is owned by the engine and // will be destroyed when the engine is destroyed. The "prototype" // allows the engine to pick different filters based on the parameters // that will be requested, and not just the "type". virtual QPixmapFilter *pixmapFilter(int /*type*/, const QPixmapFilter * /*prototype*/) { return 0; }
This function is then called four times in src/widgets/effects/qpixmapfilter.cpp, all following thispattern:
qpixmapfilter.cpp
QPixmapFilter *filter = painter->paintEngine() && painter->paintEngine()->isExtended() ? static_cast<QPaintEngineEx *>(painter->paintEngine())->pixmapFilter(type(), this) : 0; QPixmapConvolutionFilter *convolutionFilter = static_cast<QPixmapConvolutionFilter*>(filter); if (convolutionFilter) { convolutionFilter->setConvolutionKernel(d->convolutionKernel, d->kernelWidth, d->kernelHeight); convolutionFilter->d_func()->convoluteAlpha = d->convoluteAlpha; convolutionFilter->draw(painter, p, src, srcRect); return; }
....where all this code is redundant because filter is always 0.
The to-do comment should be resolved for the 5.0.0 Beta. As the header containing the function is private, source-compatibility should not be a problem.
Attachments
Issue Links
- resulted from
-
QTBUG-23524 [API] Grep the source for Qt5 todo items
- Closed
For Gerrit Dashboard: QTBUG-25069 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
22094,1 | Removed Qt5 todo comment in qpaintengineex_p.h | master | qt/qtbase | Status: MERGED | +2 | 0 |
69332,1 | Qt 5 to-do in qpainterengineex_p.h | stable | qt/qtbase | Status: ABANDONED | 0 | 0 |
97772,2 | Qt 5 to-do in qpainterengineex_p.h | 5.4 | qt/qtbase | Status: MERGED | +2 | 0 |