Details
-
Technical task
-
Resolution: Done
-
P2: Important
-
None
-
bf4d2c0582c55d3d72f3b8f4e6e321687fc19555
Description
From mailing list:
-1:
- need to use qt_safe_ {open,close}
- why the strlcopy? Can't it pass the name parameter?
- "static" missing in all functions
- coding style
- there's a QString creation between the failing system call and checking of
errno. That is a bad idea, since malloc() can modify errno. Refactor
setErrorString.
-> additionally, merge it with the _unix implementation. - the pin / unpin functions seem to be wrongly used