Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-29033 Remaining issues for Qt for Android
  3. QTBUG-29524

Android: Comments on ashmem implementation

    XMLWordPrintable

Details

    • Technical task
    • Resolution: Done
    • P2: Important
    • 5.1.0
    • Core: Other
    • None
    • bf4d2c0582c55d3d72f3b8f4e6e321687fc19555

    Description

      From mailing list:

      -1:

      • need to use qt_safe_ {open,close}
      • why the strlcopy? Can't it pass the name parameter?
      • "static" missing in all functions
      • coding style
      • there's a QString creation between the failing system call and checking of
        errno. That is a bad idea, since malloc() can modify errno. Refactor
        setErrorString.
        -> additionally, merge it with the _unix implementation.
      • the pin / unpin functions seem to be wrongly used

      Attachments

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

        Activity

          People

            tvete Paul Olav Tvete
            esabraha Eskil Abrahamsen Blomfeldt
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Gerrit Reviews

                There are no open Gerrit changes