Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-36810

Android: Remove direct use of Action strings, use dynamic lookup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1: Critical
    • Resolution: Done
    • Affects Version/s: 5.3.0
    • Fix Version/s: 5.3.0
    • Labels:
      None
    • Platform/s:
      Android

      Description

      The Bluetooth for Android port uses a lot of actions which are defined as static final String. Currently the strings are directly used. There is no guarantee that strings don't change. Therefore the static fields should rather be used.

      This requires some caching to avoid too much performance drain.

      This was highlighted by:
      https://codereview.qt-project.org/#patch,sidebyside,77809,4,src/bluetooth/android/devicediscoverybroadcastreceiver.cpp

        Attachments

          Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Activity

              People

              Assignee:
              ablasche Alex Blasche
              Reporter:
              ablasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Gerrit Reviews

                  There are no open Gerrit changes