Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-36810

Android: Remove direct use of Action strings, use dynamic lookup

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • 5.3.0
    • 5.3.0
    • Connectivity: Bluetooth
    • None
    • Android

    Description

      The Bluetooth for Android port uses a lot of actions which are defined as static final String. Currently the strings are directly used. There is no guarantee that strings don't change. Therefore the static fields should rather be used.

      This requires some caching to avoid too much performance drain.

      This was highlighted by:
      https://codereview.qt-project.org/#patch,sidebyside,77809,4,src/bluetooth/android/devicediscoverybroadcastreceiver.cpp

      Attachments

        Issue Links

          is required for

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-36712 Issues to be fixed before 5.3.0 Beta 1 release

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-36810
          # Subject Branch Project Status CR V
          79762,4 Android: Don't directly use the action string values but refer to the fields. stable qt/qtconnectivity Status: MERGED +2 0
          79835,2 Android: Don't directly use java field values stable qt/qtconnectivity Status: MERGED +2 0

          Activity

            People

              ablasche Alex Blasche
              ablasche Alex Blasche
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes