Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-43344

macOS: Regression: closeEvent called twice (still not fixed)

    XMLWordPrintable

Details

    • macOS
    • e0b5ff4ad583befbecbcbe462998e3ed80899531

    Description

      QWidget::closeEvent is called twice (it doesn't matter if the event is accepted or not).
      See attached minimal application.

      This regression was marked as fixed in QTBUG-39398, but for me it is not.

      I have Qt 5.4 statically build on osx, the patch is there, but i still can reproduce the issue using the test app in QTBUG-39398.

      i have fixed it for myself locally by not calling canQuit and calling QGuiApplication::exit(0) only if all windows did accept their close (and closed).

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-39398 Regression: closeEvent called twice

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-33235 OSX: QQuickWindow doesn't get a closeEvent on Cmd+Q

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-53365 Regression: After upgrading from 5.5.1 to 5.6.0 QCloseEvent::spontaneous doesn't work.

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Reported

          Bug - A problem which impairs or prevents the functions of the product. QTCREATORBUG-18798 Closing Qt Creator from Dock menu looses some settings

          • P2: Important - Urgent, should be fixed, but will not stop the release.
          • Closed
          resulted in

          Bug - A problem which impairs or prevents the functions of the product. QTBUG-50854 [REG 5.5->5.6]: ASSERT in kernel\qwindow.cpp, line 396 triggered when reshowing a previously hidden QDialog with a QWidget if QWidget::winId() has been called

          • P1: Critical - Urgent and Important, will STOP the release if matched with set FixVersion field. This includes regressions from the last version that are not edge cases; Data loss; Build issues; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs & Bugs critical to a deliverable. This is the highest possible priority for requirements.
          • Closed
          For Gerrit Dashboard: QTBUG-43344
          # Subject Branch Project Status CR V
          125587,2 QWidgetWindow: call base class close event impl 5.6 qt/qtbase Status: MERGED +2 0
          125588,2 Close QWidgetWindows by closing the window 5.6 qt/qtbase Status: MERGED +2 0
          125589,3 Cocoa: Don't send duplicate close events. 5.6 qt/qtbase Status: MERGED +2 0
          148319,2 Revert "QWidgetWindow: call base class close event impl". 5.6.0 qt/qtbase Status: MERGED +2 0
          158701,20 Unify window close behavior dev qt/qtbase Status: DEFERRED -2 0
          158702,1 WIP: Run QWindow close logic on QWidgetWindow close. 5.7 qt/qtbase Status: ABANDONED -2 0
          227398,2 QWidgetWindow: Immediately forward close events to QWindow 5.11 qt/qtbase Status: MERGED +2 0

          Activity

            People

              ulherman Ulf Hermann
              shaforostoff Nick Shaforostoff
              Votes:
              15 Vote for this issue
              Watchers:
              27 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews