Details
-
Bug
-
Resolution: Done
-
P2: Important
-
5.7.0
-
None
-
macOS
Description
This patch is necessary because it's required for Homebrew which is a widely used package manager and doesn't carry patches that aren't getting accepted upstream.
diff --git a/qttools/src/macdeployqt/shared/shared.cpp b/qttools/src/macdeployqt/shared/shared.cpp index 5577265..2d614cb 100644 --- a/qttools/src/macdeployqt/shared/shared.cpp +++ b/qttools/src/macdeployqt/shared/shared.cpp @@ -803,6 +803,10 @@ void changeInstallName(const QString &bundlePath, const FrameworkInfo &framework deployedInstallName = framework.deployedInstallName; } changeInstallName(framework.installName, deployedInstallName, binary); + QString canonicalInstallName = QFileInfo(framework.installName).canonicalFilePath(); + if (canonicalInstallName != framework.installName) { + changeInstallName(canonicalInstallName, deployedInstallName, binary); + } } }
I report this here because Mike McQuaid, one of the Homebrew maintainers forced me to do.
Since I do not know the technical details about this patch, if you have any question, please ask him directory. Here is the url https://github.com/MikeMcQuaid
Thank you.
Attachments
Issue Links
- is duplicated by
-
QTBUG-54086 Class RunLoopModeTracker is implemented in both my.app/Contents/Frameworks/QtCore.framework/Versions/5/QtCore and /usr/local/Cellar/qt5/5.6.1/lib/QtCore.framework/Versions/5/QtCore. One of the two will be used. Which one is undefined.
- Closed
For Gerrit Dashboard: QTBUG-56814 | ||||||
---|---|---|---|---|---|---|
# | Subject | Branch | Project | Status | CR | V |
180825,2 | macdeployqt: Add a fix for cases when qt libraries are symlinked | dev | qt/qttools | Status: MERGED | +2 | 0 |