Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-56814

macdeployqt does not work with Homebrew

    XMLWordPrintable

Details

    Description

      This patch is necessary because it's required for Homebrew which is a widely used package manager and doesn't carry patches that aren't getting accepted upstream.

      diff --git a/qttools/src/macdeployqt/shared/shared.cpp b/qttools/src/macdeployqt/shared/shared.cpp
      index 5577265..2d614cb 100644
      --- a/qttools/src/macdeployqt/shared/shared.cpp
      +++ b/qttools/src/macdeployqt/shared/shared.cpp
      @@ -803,6 +803,10 @@ void changeInstallName(const QString &bundlePath, const FrameworkInfo &framework
                   deployedInstallName = framework.deployedInstallName;
               }
               changeInstallName(framework.installName, deployedInstallName, binary);
      +        QString canonicalInstallName = QFileInfo(framework.installName).canonicalFilePath();
      +        if (canonicalInstallName != framework.installName) {
      +            changeInstallName(canonicalInstallName, deployedInstallName, binary);
      +        }
           }
       }
      

      I report this here because Mike McQuaid, one of the Homebrew maintainers forced me to do.
      Since I do not know the technical details about this patch, if you have any question, please ask him directory. Here is the url https://github.com/MikeMcQuaid

      Thank you.

      Attachments

        Issue Links

          No reviews matched the request. Check your Options in the drop-down menu of this sections header.

          Activity

            People

              sorvig Morten Sørvig
              debugger Yez Ezey
              Votes:
              4 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Gerrit Reviews

                  There are no open Gerrit changes