Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-63098

Revisit private dependencies to other Qt modules

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: P1: Critical
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: WebEngine
    • Labels:
      None
    • Technical Risk:
      Normal

      Description

      Qt WebEngine uses private include / symbols from Qt Core, Qt Gui, Qt Quick, Qt Widgets. These are not part of the public API, and therefore can change over versions.

      in src:

      src/core/api/qwebenginecookiestore_p.h:#include <QtCore/private/qobject_p.h>  -> *Done* with https://codereview.qt-project.org/#/c/216068/
      src/core/delegated_frame_node.cpp:#include <private/qsgadaptationlayer_p.h>
      src/core/render_widget_host_view_qt.cpp:#include <QtGui/private/qinputcontrol_p.h>  -> WIP patches
      src/webengine/api/qquickwebenginetestsupport_p.h:#include <private/qinputmethod_p.h>  ->  Shouldn't matter because this is for developer build
      src/webengine/api/qquickwebengineview.cpp:#include <private/qguiapplication_p.h>   -> WIP patches
      src/webengine/api/qquickwebengineview.cpp:#include <private/qquickaccessibleattached_p.h>  -> *Done* with https://codereview.qt-project.org/#/c/219460/ (in review)
      src/webengine/render_widget_host_view_qt_delegate_quick.cpp:#include <private/qquickwindow_p.h>
      src/core/render_widget_host_view_qt.cpp:#include <private/qguiapplication_p.h>  -> WIP patches
      src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp:#include <private/qquickwindow_p.h>
      src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp:#include <private/qwidget_p.h>  -> *Done* with https://codereview.qt-project.org/#/c/219463/ (in review)
      

      in tests:

      tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:#include <private/qinputmethod_p.h>  -> Shouldn't matter because this is for developer build
      

      Used types:

      QGuiApplicationPrivate
      QInputControl
      QObjectPrivate
      QPlatformInputContext
      QQuickAccessibleAttached
      QQuickWindowPrivate
      QSGInternalImageNode
      QSGLayer
      QSGRenderContext

        Attachments

          Issue Links

          For Gerrit Dashboard: QTBUG-63098
          # Subject Branch Project Status CR V

            Activity

              People

              Assignee:
              qt_webengine_team Qt WebEngine Team
              Reporter:
              kkohne Kai Köhne
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated: