Loading...

XML

Word

Printable

Type: Technical task
Resolution: Unresolved
Priority: Not Evaluated
Fix Version/s: None
Component/s: Testing: qtestlib
Labels:
None

This API (unconditional wait) enables people to write bad and flakey tests. Should this API be eventually deprecated? Maybe there are valid use cases for it? Need to look at the test first. Maybe some other primitives should be build on top of https://codereview.qt-project.org/#/c/205012/ instead?

Counting with grep in qtbase at 40fe5d43fdc6a95332d19de3e716aab5040dee19 :

qtbase/tests/auto$ grep -r "QTest::qWait(" * | wc -l
1118 <------- !!!!!

- Issue Only
- Show All Reviews
- Show Open Reviews

For Gerrit Dashboard: QTBUG-63992
#	Subject	Branch	Project	Status	CR	V
224608,2	tst_QFutureWatcher: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
224659,6	tst_QTimer: Replace unconditional qWait()s with QSignalSpy	5.11	qt/qtbase	Status: MERGED	+2	0
224754,2	tst_QEventLoop: Remove unconditional qWait()	5.11	qt/qtbase	Status: MERGED	+2	0
224813,3	tests/auto/network: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225017,2	tests/auto/dbus: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225041,7	tst_QWidget: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225063,3	tests/auto/widgets/util: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225096,2	tests/auto/widgets/kernel: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225251,5	tests/auto/widgets/dialogs: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225265,2	tests/auto/widgets/{effects,styles}: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225388,5	tests/auto/widgets/widgets: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225510,6	tests/auto/widgets/itemviews: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0
225702,3	tests/auto/widgets/graphicsview: Avoid unconditional qWait()s	5.11	qt/qtbase	Status: MERGED	+2	0